Added clang-format rule to insert braces for multiline control blocks. #1990
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…le` statements.
There was a problem hiding this comment.
Pull Request Overview
This PR applies clang-format rules to add braces for multiline control blocks, improving code readability and consistency. The changes enforce the coding standard that any multiline control flow statements should have their bodies enclosed in braces.
- Adds braces around single-line control blocks in if/else/while/for statements
- Maintains code functionality while improving formatting consistency
- Applies across multiple test and source files to establish uniform code style
Reviewed Changes
Copilot reviewed 143 out of 143 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| Tests/Pcap++Test/main.cpp | Added braces for multiline if statements in configuration setup |
| Tests/Pcap++Test/Tests/*.cpp | Added braces for control blocks in test files across various protocol implementations |
| Tests/Packet++Test/main.cpp | Added braces for configuration if statements |
| Tests/Packet++Test/Utils/TestUtils.cpp | Added braces for control flow statements in utility functions |
| Tests/Fuzzers/*.cpp | Added braces for conditional statements in fuzzing test code |
| Pcap++/src/*.cpp | Added braces for control blocks in networking device implementation files |
| Packet++/src/*.cpp | Added braces for control blocks in packet parsing and protocol layer implementations |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #1990 +/- ##
==========================================
- Coverage 83.43% 83.38% -0.05%
==========================================
Files 311 311
Lines 54989 55273 +284
Branches 12084 12065 -19
==========================================
+ Hits 45879 46091 +212
- Misses 7845 8310 +465
+ Partials 1265 872 -393
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
# Conflicts: # Packet++/src/Packet.cpp
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Application of #1962 (comment)