-
Notifications
You must be signed in to change notification settings - Fork 42
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mnemonic Editor, East Asian Translations and WonderMV #446
Conversation
krux-font-format viewer: to inspect prior to editing font.c
adjusted: font constant names, font range conditions
third-darker QR brightness for QR Viewer
RAM at the menu screen, sequence executed from left to right in one boot only – Yahboom (locale pt-BR previous saved)
|
This PR introduces two new languages and would greatly benefit from the implementation of #451. |
Sure! I was just running the same tests because you were concerned about RAM usage... did you see that the 11KB reduction in free memory in HOME increases with an additional 1KB by going to the |
I haven't noticed the memory gain after going to Backup->Numbers. Do you have a clue on what could be happening? I have tested #451 on this, and it rocks! It goes from +10K to -29K in comparison with develop branch |
No, I don't 😞 ... I'm sure there are a lot of things to optimize, but for what purpose? Why do we need to look at KB of memory when we still have MB free? |
To get the signing capacity from 10 to 100+ inputs, it was a byte-by-byte effort. It's a scarce asset we will always want available to implement new features. Even if were running on a computer, RAM efficiency is essential and goes hand in hand with simplicity, speed, and security. |
So we shouldn't aim to test RAM usage for every little piece of code, as that takes a lot of time and effort, but rather to unimport things, especially when we'll need the most RAM, i.e. when the user signs a PSBT. That's where we should focus on looking at the available RAM. This is easily achieved by removing the signing process from the Home Page and creating some logic at boot to handle the exit of the Page to do the signing process, then return to the Home Page at the respective menu when the signing finishes. |
Description
This PR addresses the feature requests from issues #401 and #380 with the new mnemonic edition page. It introduces Simplified Chinese and the long-awaited Korean translation and implements the necessary infrastructure to support different form factors for glyphs, such as those used in East Asian languages. Additionally, this PR adds support for a new device, the WonderMV, from a new manufacturer, Hiwonder.
What is the purpose of this pull request?