Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 24.09.0 #455

Merged
merged 291 commits into from
Sep 25, 2024
Merged

Release 24.09.0 #455

merged 291 commits into from
Sep 25, 2024

Conversation

odudex
Copy link
Member

@odudex odudex commented Sep 24, 2024

Description

New Device Support: WonderMV

Manufactured by HiWonder, the WonderMV is similar to Yahboom K210 Module, with a few differences, including a metal enclosure, USB-C port, and screen backlight control.

Added Support for East Asian Languages - Korean and Simplified Chinese

After implementing low-level support for different glyph form factors, we were finally able to introduce the long-awaited Korean language translation. Simplified Chinese support followed shortly thereafter.

Faster PSBT Scanning

Reduced the time required to scan larger PSBTs by optimizing processing speed.

Improved QR Code Scanning

Enhanced scan success rates in challenging conditions, such as reduced focus or scanning from greater distances.

UI Standardization

The positions of "Yes" and "No" in prompts have been inverted to standardize the UI. Affirmative actions, such as "Yes," "Go," and "Proceed," will now be positioned on the right, while "No," "Esc," and "Back" will be on the left.

Enhanced Scanning Progress Bars

QR code progress bars now provide more detailed information. For UR PSBTs, the progress bar indicates when a valid frame is captured, while for BBQR, it displays the index or position of the last successfully scanned frame.

Mnemoniocs Editor - Loading Mnemonics

When manually loading an existing mnemonic, you can now correct typos and mistakes during the review stage by simply tapping or navigating to the incorrect words. The checksum word will be highlighted in red if the entered mnemonic is invalid to help detect eventual problems.

Mnemonics Editor - New Mnemonic

When generating new mnemonics through dice rolls or camera images, you can now modify the entropy by changing some of the mnemonic words. The final word will dynamically adjust to always produce a valid checksum.

Support for Scanning Various Binary Grid Formats

In addition to TinySeed, the camera can now scan and load mnemonics from equivalent formats, such as OneKey KeyTag, or even generic binary grids, like spreadsheets with colored, squared cells.

Message Signing Using SD cards

Recently released in Sparrow, the SD card message signing workflow is now supported.

Generate Double Mnemonics from Camera

When generating a new mnemonic using the camera, users can now choose to create a "Double Mnemonic," in addition to the standard 12 and 24-word options. This feature generates a 24-word mnemonic that, when split in half, forms two valid 12-word mnemonics.

Increased Valid Touch Surface

To improve touch accuracy, especially on small touchscreens, the touch surface area of buttons has been increased to make better use of the available screen space.

Add Account Descriptor Type Support

Krux now accepts urtype.Account type QR code descriptors.

Enhanced File Exploring

File explorer now better differentiate files from folders.

Camera Adjustments for Yahboom and WondeMV

Sensitivity and exposure adjustments were made to the GC2145 sensor, enhancing the scanning success rate for Yahboom and WondeMV devices.

About Shows Board Type

Ensure you flashed the correct firmware for your device consulting the "About" menu item.

Simplified Translations

Messages and terms were simplified to reduce firmware size and maintenance.

Bugfix - Signing Messages with ":" Character

Fixed an issue where signing messages containing the ":" character would result in invalid signatures when signing at addresses.

Bugfix - Import of Base64 Encoded PSBTs from SD Card

Fixed an issue where base64 encoded PSBTs imported from an SD card were not correctly detected and parsed.

Translation Removed: Polish

Polish translation was removed due to the lack of maintainers and known users.

Code Refactor and Optimizations

Several optimizations to increase performance and code quality.

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

odudex and others added 30 commits July 30, 2024 11:04
Sign base64 PSBTs From SD card
lint
update Maixpy
3 adjusted tests for wallet_settings
Copy link

codecov bot commented Sep 24, 2024

Codecov Report

Attention: Patch coverage is 94.90385% with 53 lines in your changes missing coverage. Please review.

Project coverage is 94.67%. Comparing base (1ce3427) to head (3123de6).
Report is 258 commits behind head on main.

Files with missing lines Patch % Lines
src/krux/display.py 61.11% 14 Missing ⚠️
src/krux/pages/home_pages/sign_message_ui.py 93.37% 12 Missing ⚠️
src/krux/pages/capture_entropy.py 88.88% 6 Missing ⚠️
src/krux/pages/login.py 92.59% 4 Missing ⚠️
src/krux/pages/qr_capture.py 95.78% 4 Missing ⚠️
src/krux/pages/encryption_ui.py 78.57% 3 Missing ⚠️
src/krux/input.py 83.33% 2 Missing ⚠️
src/krux/pages/__init__.py 97.05% 2 Missing ⚠️
src/krux/pages/mnemonic_editor.py 98.97% 2 Missing ⚠️
src/krux/camera.py 96.87% 1 Missing ⚠️
... and 3 more
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #455      +/-   ##
==========================================
+ Coverage   94.65%   94.67%   +0.02%     
==========================================
  Files          57       70      +13     
  Lines        7078     7575     +497     
==========================================
+ Hits         6700     7172     +472     
- Misses        378      403      +25     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

CHANGELOG.md Outdated
File explorer now better differentiate files from folders.

### Camera Adjustments for Yahboom and WondeMV
Sensitivity and exposure adjustments were made to the GC2145 sensor, enhancing the scanning success rate for Yahboom and WondeMV devices.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"WondeMV" missing "r" becomes "WonderMV"

@@ -0,0 +1,26 @@
## Background
The examples below have been crated so that you can test the workflow for scanning both 12 and 24 word mnemonics. (Scanning the left plate for a 12 word mnemonic and both plates for 24) The resulting fingerprint from an successful scan is also incldued in the image.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"crated" missing "e" becomes "created"

- [ ] Amigo
- [ ] M5stickV
- [ ] Cube
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

to add "WonderMV" once released as a supported device.

official desktop application, [KruxInstaller](https://github.com/selfcustody/krux-installer),
available for:

> ⚠️ WARNING: Krux-Installer latest version is in it's alpha version. Maybe you can experience
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this warning as "alpha" still applicable?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@qlrd still tagged as alpha.
Fixed all other typos and issues. Thanks!

add WonderMV to bug report template
@odudex odudex merged commit 64e5ae5 into main Sep 25, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants