Fix input generation for 521bit curves #481
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Collaborator
0xturboblitz
commented
Mar 25, 2025
0xturboblitz
commented
- fix EC point padding for 521 bit curves
- rename modulus to point in findStartIndexEC as it is a point
- simplify logic
Co-authored-by: Nicolas Brugneaux <[email protected]>
Co-authored-by: Nicolas Brugneaux <[email protected]>
Co-authored-by: motemotech <[email protected]>
Co-authored-by: nicoshark <[email protected]>
Co-authored-by: thomas-senechal <[email protected]>
chore: limit the number of parallel circuits being built to 5
* add new columns in contracts readme * update contracts readme
* fix: refactor secret and passport-data management * clean things up * hadle biometric availablity state * added unsafe_secret_privateKey & unsafe_clearSecrets in usePassport for devSettingsScreen * remove setting of secret in loadingScreen as it's handled in usePassport internally
* bump version * lower target iOS version to 11 * bump version * lower ios deployment target to 15.0 * increment build * bump build * increment build * bump build * update podlock
* chore: add redirect.self.xyz to app link domains * chore: add redirect.self.xyz to android manifest * add self in the universal link path * set gestureEnabled false on Launch screen * improve ProveScreen UX * improve ProveScreen UX * implement deeplinking in mobile app and sdk * start app listener in ViewFinder * support WS connexion with complex qrcodes * remove /self path from android deeplink support --------- Co-authored-by: turboblitz <[email protected]>
This reverts commit 11f9cc4.
* fix deeplink implementation * check biometrics when pressing button on prove screen * Revert "check biometrics when pressing button on prove screen" This reverts commit fdf9545. --------- Co-authored-by: 0xturboblitz <[email protected]>
* remove biometrics.createKeys() * yarn nice
0xturboblitz
had a problem deploying
to
development
GitHub Actions
Error
0xturboblitz
temporarily deployed
to
development
GitHub Actions
Inactive
0xturboblitz
had a problem deploying
to
development
GitHub Actions
Failure
0xturboblitz
temporarily deployed
to
development
GitHub Actions
Inactive
|
ready for review |
justinhernandez
force-pushed
the
fix-input-gen-521bit-curves
branch
from
d2c06aa to
34b63d6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.