Skip to content
This repository was archived by the owner on Jan 20, 2023. It is now read-only.

fix: Convert package to ESM #149

Closed
wants to merge 84 commits into from
Closed

Conversation

UziTech
Copy link
Member

@UziTech UziTech commented Oct 3, 2021

No description provided.

pvdlg and others added 30 commits January 9, 2020 14:39
BREAKING CHANGE: Require Node.js >= 10.18
added by accident
renovate bot and others added 17 commits September 4, 2021 21:29
…mantic-release#146)

BREAKING CHANGE: the minimum required version of node is now v14.17
@UziTech UziTech force-pushed the esm-module branch 3 times, most recently from 047c1a1 to 986a54f Compare October 3, 2021 00:58
@travi
Copy link
Member

travi commented Oct 3, 2021

we'll need to coordinate this with also converting the core package and the official packages that it depends on. @gr2m has started that effort in semantic-release/github#419. there may be some details of that conversion that are worth being consistent with or giving feedback about.

instead of opening this PR against master, it would be best to create a beta branch and open the PR against that branch so that we can make a pre-release of the changes before promoting to latest

@UziTech UziTech changed the base branch from master to beta October 3, 2021 19:54
@travi
Copy link
Member

travi commented Oct 4, 2021

it looks like the beta branch might be an old existing branch? probably best to clean up that old branch and create a new one

@UziTech
Copy link
Member Author

UziTech commented Oct 4, 2021

It looks like I am unable to delete the beta branch since it is protected.

@travi
Copy link
Member

travi commented Oct 4, 2021

unable to delete the beta branch since it is protected.

ah, i think that was configured before github allowed deleting protected branches. i've updated the branch protection to allow deletions now. could you confirm that it works for you now?

@UziTech UziTech deleted the branch semantic-release:beta October 4, 2021 04:41
@UziTech UziTech closed this Oct 4, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants