Skip to content

Conversation

OnestarLee
Copy link
Collaborator

@OnestarLee OnestarLee commented Sep 4, 2025

External Contributions

This project is not yet set up to accept pull requests from external contributors.

If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.

For Internal Contributors

[CLNP-7524](https://sendbird.atlassian.net/browse/CLNP-7524)

Description Of Changes

circleci -> github actions 으로 배포 스크립트 변경하였습니다.
ios 의 경우 Okta 우회하기 위해 api key 사용하는 방법으로 변경하였습니다.
ios 에서 node_bundle 과 Pods캐시를 리셋후 정상적으로 캐싱해도 XCode빌드가 실패하는 문제가 있습니다.
정확한 원인이 확인되지 않아 ios 빌드시 해당 폴더 캐시 사용하지 않도록 변경하였습니다.
추가로 Settings에서 미사용 secrets 값들 모두 삭제하였습니다

Types Of Changes

What types of changes does your code introduce to this project?
Put an x in the boxes that apply_

  • Bugfix
  • New feature
  • Documentation (correction or otherwise)
  • Cosmetics (whitespace, appearance (ex) Prettier)
  • Build configuration
  • Improvement (refactor code)
  • Test

@OnestarLee
Copy link
Collaborator Author

/bot create ticket --test

Copy link

github-actions bot commented Sep 4, 2025

@codecov-commenter
Copy link

codecov-commenter commented Sep 4, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 11.09%. Comparing base (b8704a7) to head (892f7a8).

Additional details and impacted files
@@           Coverage Diff           @@
##             main     #259   +/-   ##
=======================================
  Coverage   11.09%   11.09%           
=======================================
  Files         360      360           
  Lines        8818     8818           
  Branches     2497     2480   -17     
=======================================
  Hits          978      978           
  Misses       7764     7764           
  Partials       76       76           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@OnestarLee OnestarLee force-pushed the feat/move-circleci-to-githubaction branch from 9777671 to b912773 Compare September 17, 2025 22:56
@OnestarLee OnestarLee force-pushed the feat/move-circleci-to-githubaction branch from 43884d1 to f020aa9 Compare September 19, 2025 11:17
@OnestarLee OnestarLee changed the title chore: migrate CI configuration from CircleCI to GitHub Actions [CLNP-7524] chore: migrate CI configuration from CircleCI to GitHub Actions Sep 19, 2025
@OnestarLee OnestarLee requested review from Copilot and bang9 September 19, 2025 11:34
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR migrates the CI/CD configuration from CircleCI to GitHub Actions for automated deployment of iOS and Android sample applications. The migration includes modernizing authentication methods and implementing optimized caching strategies.

  • Replaced CircleCI workflow configuration with GitHub Actions workflows
  • Updated iOS deployment to use App Store Connect API key authentication instead of username/password
  • Implemented conditional caching strategy for node_modules while disabling problematic iOS Pods caching

Reviewed Changes

Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.

Show a summary per file
File Description
.github/workflows/publish-sample.yml Complete GitHub Actions workflow replacing CircleCI with separate iOS and Android deployment jobs
sample/ios/fastlane/Fastfile Updated iOS Fastfile to use App Store Connect API key authentication and improved CI detection
.github/workflows/comment-bot.yml Updated bot configuration to use GitHub Actions instead of CircleCI
.github/README.md Added comprehensive documentation for GitHub Actions setup and secret configuration
.circleci/config.yml Removed CircleCI configuration file
.circleci/README.md Removed CircleCI documentation

Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.

Copy link
Collaborator

@bang9 bang9 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm~ 고생하셨습니다!

@OnestarLee OnestarLee added this pull request to the merge queue Sep 20, 2025
Merged via the queue into main with commit 220fe84 Sep 20, 2025
7 checks passed
@OnestarLee OnestarLee deleted the feat/move-circleci-to-githubaction branch September 20, 2025 03:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants