-
Notifications
You must be signed in to change notification settings - Fork 45
[CLNP-7524] chore: migrate CI configuration from CircleCI to GitHub Actions #259
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
/bot create ticket --test |
[Creating Ticket] Preparing https://github.com/sendbird/sendbird-uikit-react-native/actions/runs/17449552169 |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #259 +/- ##
=======================================
Coverage 11.09% 11.09%
=======================================
Files 360 360
Lines 8818 8818
Branches 2497 2480 -17
=======================================
Hits 978 978
Misses 7764 7764
Partials 76 76 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
9777671
to
b912773
Compare
43884d1
to
f020aa9
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the CI/CD configuration from CircleCI to GitHub Actions for automated deployment of iOS and Android sample applications. The migration includes modernizing authentication methods and implementing optimized caching strategies.
- Replaced CircleCI workflow configuration with GitHub Actions workflows
- Updated iOS deployment to use App Store Connect API key authentication instead of username/password
- Implemented conditional caching strategy for node_modules while disabling problematic iOS Pods caching
Reviewed Changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
File | Description |
---|---|
.github/workflows/publish-sample.yml |
Complete GitHub Actions workflow replacing CircleCI with separate iOS and Android deployment jobs |
sample/ios/fastlane/Fastfile |
Updated iOS Fastfile to use App Store Connect API key authentication and improved CI detection |
.github/workflows/comment-bot.yml |
Updated bot configuration to use GitHub Actions instead of CircleCI |
.github/README.md |
Added comprehensive documentation for GitHub Actions setup and secret configuration |
.circleci/config.yml |
Removed CircleCI configuration file |
.circleci/README.md |
Removed CircleCI documentation |
Tip: Customize your code reviews with copilot-instructions.md. Create the file or learn how to get started.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm~ 고생하셨습니다!
Co-authored-by: Hyungu Kang | Airen <[email protected]>
External Contributions
This project is not yet set up to accept pull requests from external contributors.
If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can setup a CLA to allow for the contribution.
For Internal Contributors
[CLNP-7524](https://sendbird.atlassian.net/browse/CLNP-7524)
Description Of Changes
circleci -> github actions 으로 배포 스크립트 변경하였습니다.
ios 의 경우 Okta 우회하기 위해 api key 사용하는 방법으로 변경하였습니다.
ios 에서 node_bundle 과 Pods캐시를 리셋후 정상적으로 캐싱해도 XCode빌드가 실패하는 문제가 있습니다.
정확한 원인이 확인되지 않아 ios 빌드시 해당 폴더 캐시 사용하지 않도록 변경하였습니다.
추가로 Settings에서 미사용 secrets 값들 모두 삭제하였습니다
Types Of Changes
What types of changes does your code introduce to this project?
Put an
x
in the boxes that apply_