Skip to content

Commit 16f7034

Browse files
authored
fix: Only react and react-dom should be peerDependencies (#324)
For npm >= v7, npm autoinstall peerDependency packages According to https://docs.npmjs.com/cli/v8/configuring-npm/package-json#peerdependencies You want to express the compatibility of your package with a host tool or library while not necessarily doing a require of this host Even though react is required, its better to show that react is the host tool
1 parent 2b5f9c0 commit 16f7034

File tree

3 files changed

+9
-19
lines changed

3 files changed

+9
-19
lines changed

package-lock.json

Lines changed: 7 additions & 11 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

package.json

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -45,14 +45,11 @@
4545
"author": "SendBird <[email protected]>",
4646
"license": "SEE LICENSE IN LICENSE.md",
4747
"peerDependencies": {
48-
"css-vars-ponyfill": "^2.3.2",
49-
"date-fns": "^2.16.1",
50-
"prop-types": "^15.7.2",
5148
"react": "^16.8.6 || ^17.0.0 || ^18.0.0",
5249
"react-dom": "^16.8.6 || ^17.0.0 || ^18.0.0"
5350
},
5451
"dependencies": {
55-
"@sendbird/chat": "^4.0.11",
52+
"@sendbird/chat": "^4.0.13",
5653
"css-vars-ponyfill": "^2.3.2",
5754
"date-fns": "^2.16.1",
5855
"prop-types": "^15.7.2"

scripts/package.template.json

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -22,14 +22,11 @@
2222
"author": "SendBird <[email protected]>",
2323
"license": "SEE LICENSE IN LICENSE.md",
2424
"peerDependencies": {
25-
"css-vars-ponyfill": "^2.3.2",
26-
"date-fns": "^2.16.1",
27-
"prop-types": "^15.7.2",
2825
"react": "^16.8.6 || ^17.0.0 || ^18.0.0",
2926
"react-dom": "^16.8.6 || ^17.0.0 || ^18.0.0"
3027
},
3128
"dependencies": {
32-
"@sendbird/chat": "^4.0.11",
29+
"@sendbird/chat": "^4.0.13",
3330
"css-vars-ponyfill": "^2.3.2",
3431
"date-fns": "^2.16.1",
3532
"prop-types": "^15.7.2"

0 commit comments

Comments
 (0)