-
Notifications
You must be signed in to change notification settings - Fork 140
[CLNP-6715]Added markAsUnread #1347
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
danney-chun
wants to merge
20
commits into
main
Choose a base branch
from
origin/feat/CLNP-6715-Added-Mark-As-Unread
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for sendbird-uikit-react ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
…/feat/markAsUnread#2
Fixed QA Issue
## For Internal Contributors * Follow the [Scaled Trunk-Based Development workflow](https://trunkbaseddevelopment.com/) * Branch naming format: `{type}/TICKET_ID/description` * Type: `feat` / `fix` / `chore` / `doc` / `release` * Receive PR review approvals * Rebase your branch with the main branch and wait for CI to pass * Squash merge your commit * Use imperative language in the title and description * Follow the provided template for PR description and squashing ### Template ``` // PR title (Required) [type]: A short description of the changes in imperative language. // PR description (Optional) Add a brief description of the changes in this PR. Bullet points are also fine. // Footer (Recommended) Fixes [<TICKET_ID>](https://sendbird.atlassian.net/browse/<TICKET_ID>) // Changelogs (Recommended) // Add (internal) at the end of each changelog if internal. ### Changelogs // Co-authors // Add this if you pair programmed or they made significant contributions to the ideas in the code and you want to thank them. Co-authored-by: Name [email protected], Name2 [email protected] ``` ### Checklist Put an `x` in the boxes that apply. You can also fill these out after creating the PR. If unsure, ask the members. This is a reminder of what we look for before merging your code. - [ ] **All tests pass locally with my changes** - [ ] **I have added tests that prove my fix is effective or that my feature works** - [ ] **Public components / utils / props are appropriately exported** - [ ] I have added necessary documentation (if appropriate) ## External Contributions This project is not yet set up to accept pull requests from external contributors. If you have a pull request that you believe should be accepted, please contact the Developer Relations team <[email protected]> with details and we'll evaluate if we can set up a [CLA](https://en.wikipedia.org/wiki/Contributor_License_Agreement) to allow for the contribution.
chrisallo
reviewed
Jul 17, 2025
chrisallo
reviewed
Jul 18, 2025
chrisallo
approved these changes
Jul 18, 2025
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm! 고생 많으셨습니다!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[feat]: Added markAsUnread.
// PR description (Optional)
ChatSDK에 markAsUnread 기능이 추가 됨에 따라, Uikit에서도 해당 기능이 사용할 수 있게 반영 되었습니다.
UX Figma
Uikit Spec
Fixes CLNP-6715
// Changelogs (Recommended)
Changelogs
Checklist
Put an
x
in the boxes that apply. You can also fill these out after creating the PR. If unsure, ask the members.This is a reminder of what we look for before merging your code.
External Contributions
This project is not yet set up to accept pull requests from external contributors.
If you have a pull request that you believe should be accepted, please contact
the Developer Relations team [email protected] with details
and we'll evaluate if we can set up a CLA to allow for the contribution.