fix(vpn): clean up temp config files on disconnect#74
Closed
Sentinel-Bluebuilder wants to merge 1 commit into
Closed
fix(vpn): clean up temp config files on disconnect#74Sentinel-Bluebuilder wants to merge 1 commit into
Sentinel-Bluebuilder wants to merge 1 commit into
Conversation
WireGuard and V2Ray config files were created in system temp directories but never deleted. WireGuard configs contain the private key in plaintext — a security risk. V2Ray configs contain node addresses and UUIDs. Now both classes track their config file path and clean up on disconnect. WireGuard configs are overwritten with zeros before deletion to scrub the private key. File permissions set to 0o600 (owner-only) on creation. Fixes #40
Author
|
Superseded by #87 — rebased onto current |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
disconnect()0o600(owner-only) immediately after creationsentinel-js-sdk*) are removed after cleanupcleanup()method for manual/early cleanupDetails
Temp config files created in system temp directories were never deleted. WireGuard configs contain the private key in plaintext, making this both a disk leak and a security risk. V2Ray configs contain node addresses and UUIDs.
Fixes #40
Test plan
writeConfig()setsconfigPathand applieschmod 0o600(WireGuard)disconnect()removes the config file and its parent temp dircleanup()is safe to call multiple times or with no config writtendisconnect()kills process and cleans up config🤖 Generated with Claude Code