fix(v2ray): use dynamic port for SOCKS5 inbound instead of hardcoded 1080#86
Open
Sentinel-Bluebuilder wants to merge 2 commits into
Conversation
…1080 Port 1080 is commonly used by other proxy software. If already in use, V2Ray fails to start with 'address already in use' after the session payment is already made, wasting tokens. Now uses find-free-ports (already a dependency) for both API and SOCKS inbound ports. The assigned SOCKS port is exposed via the socksPort property so callers know where to connect. Fixes sentinel-official#36 Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
3 tasks
…te by default Per maintainer feedback: instead of always auto-picking the SOCKS port, accept an optional port in the V2Ray constructor. Default (0) preserves the auto-allocate behavior; an explicit port forces a fixed, predictable SOCKS inbound. apiPort (internal stats inbound) stays auto-allocated. findFreePorts(2) -> findFreePorts(needSocks ? 2 : 1).
Author
|
Revised per your feedback. The SOCKS port is now customizable instead of always auto-allocated:
One design note: I kept the requested port on the instance ( |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Rebased onto current
development(replaces #72, auto-closed after retarget frommain→developmentdue to base divergence). Single commit, same fix, cleanly rebased ontodevelopmentHEAD732bf85.