Update cleanup #186
Open
Update cleanup #186
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ersion updated necessary options Enabled logs Switched user feedback with new API
…ersion Cleaned TODO items now unnecessary due to update
|
Let's merge when the new plugin version is out |
stefanosiano
commented
Jul 24, 2025
| @@ -181,43 +180,7 @@ private void launchUserFeedback(SentryId sentryId) { | |||
| options.setSubmitButtonLabel("Submit"); | |||
| options.setCancelButtonLabel("Cancel"); | |||
| options.setUseSentryUser(false); | |||
There was a problem hiding this comment.
by default we use the sentry user to fill the name and email of the feedback.
We should just decide what we want for the demo (i guess it makes sense to keep the sentry user)
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #186 +/- ##
=====================================
Coverage 0.00% 0.00%
=====================================
Files 16 16
Lines 899 885 -14
Branches 65 65
=====================================
+ Misses 899 885 -14 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
updated Sentry Android Gradle Plugin version to upgrade Android SDK version
Cleaned TODO items now unnecessary due to update