Skip to content

Conversation

armcknight
Copy link
Collaborator

Moved everything core data related to CoreDataController. Centralizing it helps maintain both the database code, and the UI/controller/etc code it used to be sprinkled throughout.

@armcknight armcknight requested a review from kpujjigit as a code owner July 17, 2025 23:53
Copy link

codecov bot commented Jul 17, 2025

Codecov Report

Attention: Patch coverage is 34.92063% with 82 lines in your changes missing coverage. Please review.

Project coverage is 37.382%. Comparing base (5663891) to head (9e1a17c).
Report is 5 commits behind head on master.

Files with missing lines Patch % Lines
EmpowerPlant/CoreDataController.swift 29.629% 76 Missing ⚠️
EmpowerPlant/EmpowerPlantViewController.swift 70.000% 3 Missing ⚠️
EmpowerPlant/Product.swift 62.500% 3 Missing ⚠️
Additional details and impacted files

Impacted file tree graph

@@              Coverage Diff              @@
##            master      #117       +/-   ##
=============================================
- Coverage   37.877%   37.382%   -0.496%     
=============================================
  Files           10        10               
  Lines         1027       955       -72     
  Branches       323       324        +1     
=============================================
- Hits           389       357       -32     
+ Misses         629       591       -38     
+ Partials         9         7        -2     
Files with missing lines Coverage Δ
EmpowerPlant/AppDelegate.swift 93.023% <ø> (+27.854%) ⬆️
EmpowerPlant/ListAppViewController.swift 0.000% <ø> (ø)
EmpowerPlant/SceneDelegate.swift 66.666% <ø> (+21.839%) ⬆️
EmpowerPlant/ShoppingCart.swift 26.190% <ø> (ø)
EmpowerPlant/Utils.swift 80.000% <ø> (+37.142%) ⬆️
EmpowerPlant/EmpowerPlantViewController.swift 68.487% <70.000%> (+8.127%) ⬆️
EmpowerPlant/Product.swift 62.500% <62.500%> (ø)
EmpowerPlant/CoreDataController.swift 29.629% <29.629%> (ø)

... and 1 file with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5663891...9e1a17c. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant