Skip to content

Conversation

@HimanshuRanka
Copy link
Collaborator

Briefly describe the feature or bug that this PR addresses.

Added a backend endpoint to add emails to the newsletter. (Just code, not a mergeable branch yet)

Please link the Airtable ticket associated with this PR.

Describe the steps you took to test the feature/bugfix introduced by this PR.

Does any infrastructure work need to be done before this PR can be pushed to production?

Comment on lines +17 to +19
sheet_name = "Sheet1"
spreadsheet_id = ""
range_name = "!A1:B1"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NP: Will we eventually move this to a constants file or .env? I know these are testing values but might be cleaner to keep them somewhere where we store constants.

Comment on lines -72 to -79
jupyter-client~=6.1.11
jupyter-core~=4.7.1
jupyter-packaging~=0.9.2
jupyter-server~=1.6.4
jupyterlab~=3.0.14
jupyterlab-pygments~=0.1.2
jupyterlab-server~=2.5.0
jupyterlab-widgets~=1.0.0
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Saw your message about removing this diff but I thought I would just add a reminder :)

Copy link
Contributor

@Gurmie12 Gurmie12 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Otherwise, LGTM 👍🏽

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants