Update produceevent.json #560
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fjtirado
force-pushed
the
change-data-from-string-to-object
branch
from
51a1ed2 to
d7ab67e
Compare
ricardozanini
approved these changes
Apr 25, 2025
Signed-off-by: fjtirado <[email protected]>
fjtirado
force-pushed
the
change-data-from-string-to-object
branch
from
d7ab67e to
3a6818a
Compare
masayag
reviewed
Apr 27, 2025
| @@ -8,7 +8,8 @@ | |||
| "minLength": 1 | |||
| }, | |||
| "data": { | |||
| "type": "string", | |||
| "type": "object", | |||
There was a problem hiding this comment.
According to the spec this can be either a string or an Object.
If this shouldn't be a string, can you update the description to reflect the change?
If object type, a custom object to become the data (payload) of produced event.
There was a problem hiding this comment.
perhaps this description needs to be updated as well:
https://github.com/serverlessworkflow/sdk-java/pull/561/files#diff-a1593297ec9764a50a83b736ce196d5272b2b4281ae73613f10d742598638568R21
There was a problem hiding this comment.
This schema is just an utility to make the generator work. In order the generator to work for both string and object, the generated POJO should return a JsonNode.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
Special notes for reviewers:
Additional information (if needed):