Add OpenAPI task implementation #804
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitrii Tikhomirov <[email protected]>
Signed-off-by: Dmitrii Tikhomirov <[email protected]>
Signed-off-by: Dmitrii Tikhomirov <[email protected]>
|
I'm gonna add more tests soon |
fjtirado
reviewed
Sep 23, 2025
There was a problem hiding this comment.
Since this class is already defined here https://github.com/serverlessworkflow/sdk-java/blob/main/impl/http/src/main/java/io/serverlessworkflow/impl/executors/http/HttpExecutor.java#L207-L218
I think we should make it public and reuse here
fjtirado
reviewed
Oct 6, 2025
Comment on lines
+56
to
+66
| WorkflowContext workflowContext, TaskContext taskContext, WorkflowModel input) { | ||
| String operationId = task.getWith().getOperationId(); | ||
| URI openAPIEndpoint = targetSupplier.apply(workflowContext, taskContext, input); | ||
| OpenAPIProcessor processor = new OpenAPIProcessor(operationId, openAPIEndpoint); | ||
| OperationDefinition operation = processor.parse(); | ||
|
|
||
| OperationPathResolver pathResolver = | ||
| new OperationPathResolver( | ||
| operation.getPath(), | ||
| application, | ||
| task.getWith().getParameters().getAdditionalProperties()); |
There was a problem hiding this comment.
I think all this stuff should be moved to init method (thy are always the same for different executions, so they only need to be processed once)
fjtirado
reviewed
Oct 6, 2025
Comment on lines
+70
to
+93
| HttpCallAdapter httpCallAdapter = | ||
| new HttpCallAdapter() | ||
| .auth(task.getWith().getAuthentication()) | ||
| .body(operation.getBody()) | ||
| .contentType(operation.getContentType()) | ||
| .headers( | ||
| operation.getParameters().stream() | ||
| .filter(p -> "header".equals(p.getIn())) | ||
| .collect(Collectors.toUnmodifiableSet())) | ||
| .method(operation.getMethod()) | ||
| .query( | ||
| operation.getParameters().stream() | ||
| .filter(p -> "query".equals(p.getIn())) | ||
| .collect(Collectors.toUnmodifiableSet())) | ||
| .redirect(task.getWith().isRedirect()) | ||
| .target(pathResolver.resolve(workflowContext, taskContext, input)) | ||
| .workflowParams(task.getWith().getParameters().getAdditionalProperties()); | ||
|
|
||
| WorkflowException workflowException = null; | ||
|
|
||
| for (var server : operation.getServers()) { | ||
| CallHTTP callHTTP = httpCallAdapter.server(server).build(); | ||
| HttpExecutor executor = new HttpExecutor(); | ||
| executor.init(callHTTP, workflow, application, resourceLoader); |
There was a problem hiding this comment.
Same hre the HttpExecutor,init should be called on OpenApiExecutor.init.
The idea is to keep the apply method as minimum as possible
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
Fix #477
Special notes for reviewers:
Additional information (if needed):]