Add initial RunContainer Task support #942
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Dmitrii Tikhomirov <[email protected]> Signed-off-by: Dmitrii Tikhomirov <[email protected]>
treblereel
force-pushed
the
ContainerTask
branch
from
32a97cf to
cdc2557
Compare
Signed-off-by: Dmitrii Tikhomirov <[email protected]>
treblereel
force-pushed
the
ContainerTask
branch
from
4384a68 to
a8f5dd5
Compare
fjtirado
reviewed
Nov 4, 2025
...r/src/main/java/io/serverlessworkflow/impl/container/executors/StringExpressionResolver.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Dmitrii Tikhomirov <[email protected]>
fjtirado
requested changes
Nov 5, 2025
Signed-off-by: fjtirado <[email protected]>
Signed-off-by: fjtirado <[email protected]>
Review comments
fjtirado
approved these changes
Nov 6, 2025
There was a problem hiding this comment.
Great work!
Before merging I think @ricardozanini should review this container handling block https://github.com/serverlessworkflow/sdk-java/pull/942/files#diff-124b1b11448a7a123f2b5b8b30d8a10568d3cdbb69aed81169350425ee4ea070R139-R199
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Many thanks for submitting your Pull Request ❤️!
What this PR does / why we need it:
Special notes for reviewers:
Additional information (if needed):