Skip to content

Conversation

amin-nikanjam
Copy link

@amin-nikanjam amin-nikanjam commented Sep 5, 2025

Please specify parts of this PR update:

  • Specification
  • Schema
  • Examples
  • Extensions
  • Use Cases
  • Community
  • CTK
  • Other

Discussion or Issue link:

What this PR does:

Additional information:

Copy link
Member

@ricardozanini ricardozanini left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you! I have a few questions if you don't mind.

@cdavernas
Copy link
Member

@amin-nikanjam Could you please sign-off your commits?

@amin-nikanjam
Copy link
Author

@amin-nikanjam Could you please sign-off your commits?

Done!

@cdavernas
Copy link
Member

@amin-nikanjam DCO is still not passing. Please follow the steps enumerated in the following link to ensure it checks: https://github.com/serverlessworkflow/specification/pull/1116/checks?check_run_id=49885563716

@cdavernas
Copy link
Member

@amin-nikanjam Why are we not supporting stdio transport, too? I feel it is but trivial to add support for it, isn't it?

@amin-nikanjam
Copy link
Author

amin-nikanjam commented Sep 9, 2025

@amin-nikanjam Why are we not supporting stdio transport, too? I feel it is but trivial to add support for it, isn't it?

Right, we are not supporting the stdio now. While in MCP spec it is clarified that "Clients SHOULD support stdio whenever possible", we can add it.

@ricardozanini
Copy link
Member

@amin-nikanjam apart from adding stido, can you please check the CI?

@amin-nikanjam amin-nikanjam force-pushed the main branch 2 times, most recently from b57bac1 to fbade4a Compare September 9, 2025 19:22
@ricardozanini
Copy link
Member

@amin-nikanjam can you please squash and sign your commit?

@amin-nikanjam
Copy link
Author

@amin-nikanjam can you please squash and sign your commit?

sure, I will wrap it up in a few days.

@amin-nikanjam
Copy link
Author

amin-nikanjam commented Sep 29, 2025

@amin-nikanjam can you please squash and sign your commit?

sure, I will wrap it up in a few days.

@ricardozanini @cdavernas So, I checked the MCP spec and several implementations, in the spec it's clarified that for STDIO, "the client launches the MCP server as a subprocess", so the client has to have the "server_path" to run it. Moreover, after initialization, the client should send "JSON-RPC messages to stdin and receive messages from the server using stdout". What is the best way to include it in the specification? like a "Shell Process"?

@cdavernas
Copy link
Member

@amin-nikanjam I think there’s some confusion here. The client launching the server as a stdio subprocess is simply an implementation detail—it doesn’t require a dedicated task in the spec. The MCP call itself must support both transport modes; it’s up to implementers how they handle the subprocess. In practice, supporting both is straightforward, and there’s no need to over-specify things at the level of “shell process” in the spec.

@amin-nikanjam
Copy link
Author

@amin-nikanjam I think there’s some confusion here. The client launching the server as a stdio subprocess is simply an implementation detail—it doesn’t require a dedicated task in the spec. The MCP call itself must support both transport modes; it’s up to implementers how they handle the subprocess. In practice, supporting both is straightforward, and there’s no need to over-specify things at the level of “shell process” in the spec.

Got it. I made the necessary changes and pushed the commit.

@ricardozanini
Copy link
Member

@amin-nikanjam I think you rebased your fork with the latest commits from main. You can either rebase it again and work through your local git logs to pick the correct commits or open a new PR with a fresh branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants