-
-
Couldn't load subscription status.
- Fork 161
Add creating missing SQLite database files #400
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add creating missing SQLite database files #400
Conversation
|
Thanks for the PR on this. I just ran into this issue myself. Regarding your comment:
Do you know what version this started happening in? |
|
I believe 9.x or 8.x, I'll have to see the blame. |
|
Thanks! If it goes back that far with Laravel, should we even merge this? I was able to resolve my issue by having proper permissions on my Docker Volumes with Laravel 11. Once I had the correct permissions, the auomations worked perfectly and created my database. |
It doesn't go that far IMHO. In any case, I think older Laravel apps would benefit from this on staging and development, especially if you are on the path to upgrade. |
|
Thanks for your efforts on this PR! As I mentioned in the other post, I spent a ton of time refactoring the Laravel Automations script: What's new in my refactorI decided to NOT include a "touch" for creating SQLite database file. My reasonLaravel will create this for you automatically with Instead, you can see that I added helpful logic to help debug if a SQLite file does not exist when we test the DB connection: https://github.com/serversideup/docker-php/blob/280-create-a-frankenphp-variation/src/common/etc/entrypoint.d/lib/laravel/test-db-connection.php Let me know your thoughts on my approach. I greatly appreciate your intentions on this PR and would gladly review any other improvements that you suggest 👍 |
This PR allows the container to start and create missing the SQLite databases set by the application.
It's part of the container
AUTORUN_LARAVELscripts. It runs before the migrations. Is opt-in by default, mostly because usually production apps run on non-SQLite but PR/preview/staging apps sometimes do spin SQLite for testing or pure convenience.The way it works is through the
AUTORUN_LARAVEL_TOUCH_SQLITEenvironment value, which by default isfalse:true,1ordefault, it will pick the default connection.default, telescope, custom, it will find the connection names, and create each database file.This is done by checking if the driver is
sqliteand the file doesn't exist. If it's not SQLite, it fails. If the database file already exists, doesn't do anything.Note
Newer Laravel versions do create the SQLite database file when force migrating. Outside that command, it won't.