Skip to content

Continue parsing instead of stopping on script in xml5ever. #683

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Continue parsing instead of stopping on script in xml5ever. #683

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion xml5ever/src/driver.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,7 @@ use crate::tendril;
use crate::tendril::stream::{TendrilSink, Utf8LossyDecoder};
use crate::tendril::StrTendril;
use markup5ever::buffer_queue::BufferQueue;
use markup5ever::TokenizerResult;

/// All-encompasing parser setting structure.
#[derive(Clone, Default)]
Expand Down Expand Up @@ -64,7 +65,7 @@ impl<Sink: TreeSink> TendrilSink<tendril::fmt::UTF8> for XmlParser<Sink> {
fn process(&mut self, t: StrTendril) {
self.input_buffer.push_back(t);
// FIXME: Properly support </script> somehow.
let _ = self.tokenizer.feed(&self.input_buffer);
while let TokenizerResult::Script(_) = self.tokenizer.feed(&self.input_buffer) {}
}

// FIXME: Is it too noisy to report every character decoding error?
Expand Down
Loading