SES-4753 - New message sheet string changes #1652
Merged
+84
−16
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if (uiState.showUrlDialog) { | ||
| OpenURLAlertDialog( | ||
| url = helpUrl, | ||
| onDismissRequest = { viewModel.onCommand(NewMessageViewModel.Commands.ToggleUrlDialog) } |
There was a problem hiding this comment.
I know it's a bit more verbose but I think it's always good to be explicit with these commands. Technically a dismiss request wouldn't exactly toggle the dialog, it's always a "hide". Same with the help button which is always a show.
It avoids getting into unexpected states.
There was a problem hiding this comment.
Makes sense, I'll update the commands to have both show and dismiss.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes new error strings for Account ID and Ons. This also includes showing a modal with the updated Zendesk link when clicking the tooltip test.
Some validations we also updated to meet some criteria:
This error state appears when the user enters a string in the input field that matches the length of an Account ID (66 characters), starts with “05”, but is not valid hex.
Should also appear if the user enters a blinded ID or group ID which starts with, “15” or “03” and is the length of a blinded ID or group ID, even if it’s a valid blinded ID or group ID we should error and display that this is an invalid Account ID.