Skip to content

Automated testing #52

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: dev
Choose a base branch
from
Open

Automated testing #52

wants to merge 3 commits into from

Conversation

Aerilym
Copy link
Collaborator

@Aerilym Aerilym commented Apr 16, 2025

No description provided.

@Copilot Copilot AI review requested due to automatic review settings April 16, 2025 23:42
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR introduces automated testing utilities for a Playwright project and updates testing configurations to support new e2e test scenarios.

  • Added utility functions in utils.ts for interacting with elements by test IDs.
  • Introduced new test cases in test.spec.ts to validate page navigation, dialogs, and TOS acceptance.
  • Updated project configuration files (playwright.config.ts and jest.config.js) along with a new type definition for test IDs.

Reviewed Changes

Copilot reviewed 6 out of 10 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/playwright/tests/utils.ts New utility functions for clicking elements and TOS agreement with a potential naming inconsistency for the page parameter.
packages/playwright/tests/types/testing.ts Added type union for DataTestId values used in testing.
packages/playwright/tests/test.spec.ts New test specs to verify web page behavior.
packages/playwright/playwright.config.ts New Playwright configuration for test execution.
packages/playwright/jest.config.js Jest configuration extended from a shared base config.
packages/playwright/README.md Basic readme added for package documentation.
Files not reviewed (4)
  • packages/playwright/package.json: Language not supported
  • packages/playwright/test-results/.last-run.json: Language not supported
  • packages/playwright/tsconfig.json: Language not supported
  • pnpm-lock.yaml: Language not supported
Comments suppressed due to low confidence (2)

packages/playwright/tests/utils.ts:6

  • [nitpick] The parameter name 'window' is unconventional in Playwright tests (typically 'page'). Consider renaming it for consistency with the rest of the codebase.
  window: Page,

packages/playwright/tests/utils.ts:24

  • [nitpick] The parameter 'window' could be renamed to 'page' to align with common Playwright conventions and improve readability, as seen in other parts of the code.
  window: Page,

@Aerilym Aerilym force-pushed the feat/QA-423/automated_testing branch from 556abe1 to 4465c8b Compare April 16, 2025 23:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants