Fixed layouts for league thumb/cover#121
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixed the layouts for league covers/thumbs to avoid the possibility of overlapping/clipping items like in the below example:
Reworked into 3 possible layouts that are switched automatically according to what query params are present:
Type of Change
Changes Made
Refactored canvas element draw logic in
generateLeagueImage()into a centralized functiondrawContents()so layout variables can be updated in one place instead of several (and significantly reducing code duplication). The new function also contains the logic for the layout switching. This should also make it easy to add other layouts in the future.Testing
Changes tested locally with
/:league/thumband/:league/coverand relevant query paramsTest Details:
Screenshots/Examples
Layout 1 (League Only, game-thumbs OG)
Current
New (pretty much identical)
Layout 2 (League, Title/subtitle)
Current (inconsistent spacing)
New (fixed)
Layout 3 (League, Title/subtitle, Icon)
Current (broken)
New (fixed)
Checklist