fix: replace static mut ID_COUNTER with AtomicU64

[Jay-Jay-Tee]

Closes #62

Problem

next_id() in src/storage/ram.rs uses a raw static mut to generate entry IDs. In Rust, any access to static mut is undefined behavior per the reference and Miri, even from a single thread. The compiler is free to reorder, cache, or elide reads and writes to it.

The app also uses Arc<RwLock> and a tokio runtime, so next_id() can be called from multiple threads, making this a data race that could produce duplicate or skipped IDs and silently corrupt clipboard history and vault storage lookups.

Fix

Replace with AtomicU64::fetch_add:

static ID_COUNTER: AtomicU64 = AtomicU64::new(0);

pub fn next_id() -> EntryId {
    ID_COUNTER.fetch_add(1, Ordering::Relaxed)
}

No unsafe block needed. Thread-safe. Zero runtime overhead.

Files changed

• src/storage/ram.rs

[Jay-Jay-Tee]

@shaaravraghu, do check this out!