Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(sidebar blocks): adds sidebar-16 block with components and styles #5889

Conversation

Jacksonmills
Copy link
Contributor

@Jacksonmills Jacksonmills commented Nov 21, 2024

Introduces a new sidebar-16 block with an inset sidebar and site header navigation.
Includes components for main navigation, projects, secondary navigation, and user menu.
Updates registry and scripts to include the new sidebar block.

Addresses: #5629

image
image

Introduces a new sidebar-16 block with an inset sidebar and site header navigation.
Includes components for main navigation, projects, secondary navigation, and user menu.
Updates registry and scripts to include the new sidebar block.
Introduces a new sidebar header with a menu and menu items
Adjusts padding in the page header for better alignment
…egistry

Integrates NavigationHeaderMenu component into sidebar-16 pages for improved navigation structure. Updates import paths and registry entries accordingly.
Adds header navigation and various UI components
Improves sidebar functionality and responsiveness
Updates descriptions and imports for consistency
Copy link

vercel bot commented Nov 21, 2024

@Jacksonmills is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

@Jacksonmills
Copy link
Contributor Author

@shadcn I think I’ve set everything up correctly, but please let me know if I missed anything.

Also, feel free to share any suggestions or feedback regarding the sidebar setup. Thanks in advance! 🌟

@eugenegalaxy
Copy link

Waiting patiently for this fix. :)

Really want that navigation header bar above the sidebar.

Copy link

vercel bot commented Nov 21, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ui ❌ Failed (Inspect) Jan 27, 2025 0:24am

@shadcn
Copy link
Collaborator

shadcn commented Nov 24, 2024

@Jacksonmills This looks awesome. Thanks for taking the time to work on this. I'll do a full code review.

Is responsive done? I noticed a small issue with the navigation menu.

Ax8L2Uvy

(Note: Totally okay to have a simpler header for the sidebar example with some simple menu items. We can do a full navigation one when we do dashboard-xx blocks)

@Jacksonmills
Copy link
Contributor Author

Jacksonmills commented Nov 24, 2024

@Jacksonmills This looks awesome. Thanks for taking the time to work on this. I'll do a full code review.

Is responsive done? I noticed a small issue with the navigation menu.

Ax8L2Uvy

(Note: Totally okay to have a simpler header for the sidebar example with some simple menu items. We can do a full navigation one when we do dashboard-xx blocks)

Ah totally, I will simplify the header nav and clean up mobile 🫡

@alekfestekjian
Copy link

any updates? @Jacksonmills @shadcn really would like to use this!

@niemyjski
Copy link

Is there anything we can help out with?

@niemyjski
Copy link

Any idea what is left or what is preventing merging? Anything we can do to help?

@thedevdavid
Copy link

Now that block contributions are open, is there anything stopping this from merging, @shadcn ?

@Jacksonmills
Copy link
Contributor Author

Jacksonmills commented Jan 20, 2025

@Jacksonmills This looks awesome. Thanks for taking the time to work on this. I'll do a full code review.

Is responsive done? I noticed a small issue with the navigation menu.

(Note: Totally okay to have a simpler header for the sidebar example with some simple menu items. We can do a full navigation one when we do dashboard-xx blocks)

@shadcn

The header is now simplified and matches your restructure. During testing, I came across a bug with the controlled sidebar state. The mobile sidebar fails to toggle properly when triggered by a controlled button, which is why a toggle within the provider is necessary for mobile (for now). I plan to take care of this in a separate PR, and will update sidebar-16 to rely on a unified toggle in the sticky header.

Let me know what you think!

@SamStenner
Copy link

I've been checking this PR every day for 2 months 😂
Pls @shadcn 🙏🙏

@shadcn
Copy link
Collaborator

shadcn commented Jan 27, 2025

on it.

@shadcn
Copy link
Collaborator

shadcn commented Jan 27, 2025

@Jacksonmills I made a few minor changes to the code: separate component for the header and used values from tailwind config for the header height.

merging this now.

@kodiakhq kodiakhq bot merged commit dd71498 into shadcn-ui:main Jan 27, 2025
5 of 6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants