-
Notifications
You must be signed in to change notification settings - Fork 5.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(sidebar blocks): adds sidebar-16 block with components and styles #5889
feat(sidebar blocks): adds sidebar-16 block with components and styles #5889
Conversation
Introduces a new sidebar-16 block with an inset sidebar and site header navigation. Includes components for main navigation, projects, secondary navigation, and user menu. Updates registry and scripts to include the new sidebar block.
Introduces a new sidebar header with a menu and menu items Adjusts padding in the page header for better alignment
…egistry Integrates NavigationHeaderMenu component into sidebar-16 pages for improved navigation structure. Updates import paths and registry entries accordingly.
Adds header navigation and various UI components Improves sidebar functionality and responsiveness Updates descriptions and imports for consistency
@Jacksonmills is attempting to deploy a commit to the shadcn-pro Team on Vercel. A member of the Team first needs to authorize it. |
@shadcn I think I’ve set everything up correctly, but please let me know if I missed anything. Also, feel free to share any suggestions or feedback regarding the sidebar setup. Thanks in advance! 🌟 |
Waiting patiently for this fix. :) Really want that navigation header bar above the sidebar. |
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
@Jacksonmills This looks awesome. Thanks for taking the time to work on this. I'll do a full code review. Is responsive done? I noticed a small issue with the navigation menu. (Note: Totally okay to have a simpler header for the |
Ah totally, I will simplify the header nav and clean up mobile 🫡 |
any updates? @Jacksonmills @shadcn really would like to use this! |
Is there anything we can help out with? |
Any idea what is left or what is preventing merging? Anything we can do to help? |
Now that block contributions are open, is there anything stopping this from merging, @shadcn ? |
The header is now simplified and matches your restructure. During testing, I came across a bug with the controlled sidebar state. The mobile sidebar fails to toggle properly when triggered by a controlled button, which is why a toggle within the provider is necessary for mobile (for now). I plan to take care of this in a separate PR, and will update sidebar-16 to rely on a unified toggle in the sticky header. Let me know what you think! |
I've been checking this PR every day for 2 months 😂 |
on it. |
@Jacksonmills I made a few minor changes to the code: separate component for the header and used values from tailwind config for the header height. merging this now. |
Introduces a new sidebar-16 block with an inset sidebar and site header navigation.
Includes components for main navigation, projects, secondary navigation, and user menu.
Updates registry and scripts to include the new sidebar block.
Addresses: #5629