Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: code block overflow layout #6462

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

m4xshen
Copy link

@m4xshen m4xshen commented Jan 26, 2025

This PR fixes the code block incorrect layout when content is overflow.

Before:

Screen.Recording.2025-01-26.at.11.44.27.PM.mov

After:

Screen.Recording.2025-01-26.at.11.44.47.PM.mov

Copy link

vercel bot commented Jan 26, 2025

@m4xshen is attempting to deploy a commit to the shadcn-pro Team on Vercel.

A member of the Team first needs to authorize it.

Copy link

vercel bot commented Jan 28, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated (UTC)
ui ✅ Ready (Inspect) Visit Preview Jan 28, 2025 0:35am

Copy link
Collaborator

@shadcn shadcn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ah I saw this the other day and was on my list to fix. Thanks so much for looking into it. Annoying bug. Appreciate it.

I noticed one minor issue. Looks like we lost the top border radius. Can you take a look please?

KdZwH35u

@shadcn shadcn added bug Something isn't working area: www labels Jan 28, 2025
@m4xshen m4xshen requested a review from shadcn January 28, 2025 18:09
@m4xshen
Copy link
Author

m4xshen commented Jan 28, 2025

I noticed one minor issue. Looks like we lost the top border radius.

Fixed. Thanks for catching that! I didn't notice it in the dark mode.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: www bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants