Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix precompiledTargetModule tests #6236

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

cheneym2
Copy link
Collaborator

No description provided.

@cheneym2
Copy link
Collaborator Author

/format

@slangbot
Copy link
Contributor

🌈 Formatted, please merge the changes from this PR

cheneym2 added a commit to cheneym2/slang that referenced this pull request Jan 31, 2025
@cheneym2 cheneym2 added the pr: non-breaking PRs without breaking changes label Jan 31, 2025
@cheneym2 cheneym2 force-pushed the cheneym2/precompiledTarget2 branch from 04abde3 to fac47fb Compare January 31, 2025 16:31
@cheneym2
Copy link
Collaborator Author

/format

@slangbot
Copy link
Contributor

🌈 Formatted, please merge the changes from this PR

cheneym2 added a commit to cheneym2/slang that referenced this pull request Jan 31, 2025
@cheneym2 cheneym2 force-pushed the cheneym2/precompiledTarget2 branch from 1803610 to a55f68a Compare February 3, 2025 15:23
@cheneym2
Copy link
Collaborator Author

cheneym2 commented Feb 3, 2025

/format

@slangbot
Copy link
Contributor

slangbot commented Feb 3, 2025

🌈 Formatted, please merge the changes from this PR

cheneym2 added a commit to cheneym2/slang that referenced this pull request Feb 3, 2025
In the SPIR-V backend of Slang, compiling a shader
that contains some modules with precompiled target
blobs will produce only a "glue" SPIR-V output which
needs to be linked with the assorted precompiled
blobs to be complete.

Closes shader-slang#5435
Closes shader-slang#6170
@cheneym2 cheneym2 force-pushed the cheneym2/precompiledTarget2 branch from be51963 to 4753535 Compare February 3, 2025 17:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants