-
Notifications
You must be signed in to change notification settings - Fork 245
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix precompiledTargetModule tests #6236
Draft
cheneym2
wants to merge
1
commit into
shader-slang:master
Choose a base branch
from
cheneym2:cheneym2/precompiledTarget2
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cheneym2
force-pushed
the
cheneym2/precompiledTarget2
branch
from
January 31, 2025 16:12
5e6840d
to
3f2ed2a
Compare
/format |
🌈 Formatted, please merge the changes from this PR |
cheneym2
added a commit
to cheneym2/slang
that referenced
this pull request
Jan 31, 2025
…arget2 Format code for PR shader-slang#6236
cheneym2
force-pushed
the
cheneym2/precompiledTarget2
branch
from
January 31, 2025 16:31
04abde3
to
fac47fb
Compare
/format |
🌈 Formatted, please merge the changes from this PR |
cheneym2
added a commit
to cheneym2/slang
that referenced
this pull request
Jan 31, 2025
…arget2 Format code for PR shader-slang#6236
cheneym2
force-pushed
the
cheneym2/precompiledTarget2
branch
from
February 3, 2025 15:23
1803610
to
a55f68a
Compare
/format |
🌈 Formatted, please merge the changes from this PR |
cheneym2
added a commit
to cheneym2/slang
that referenced
this pull request
Feb 3, 2025
…Target2 Format code for PR shader-slang#6236
In the SPIR-V backend of Slang, compiling a shader that contains some modules with precompiled target blobs will produce only a "glue" SPIR-V output which needs to be linked with the assorted precompiled blobs to be complete. Closes shader-slang#5435 Closes shader-slang#6170
cheneym2
force-pushed
the
cheneym2/precompiledTarget2
branch
from
February 3, 2025 17:05
be51963
to
4753535
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.