Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

maxtessfactor attribute should take a floating point value #6289

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

maxtessfactor attribute should take a floating point value #6289

wants to merge 3 commits into from
+99 −4

Conversation

jkwak-work
Copy link
Collaborator

@jkwak-work jkwak-work commented Feb 5, 2025 •
edited
Loading

It looks like [maxtessfactor(XX)] is useful only when targeting HLSL.
There isn't corresponding keyword for GLSL nor SPIR-V.

@jkwak-work jkwak-work added the pr: non-breaking PRs without breaking changes label Feb 5, 2025
@jkwak-work jkwak-work requested a review from csyonghe February 5, 2025 07:39
@jkwak-work jkwak-work self-assigned this Feb 5, 2025
@jkwak-work jkwak-work requested a review from a team as a code owner February 5, 2025 07:39
@jkwak-work
Copy link
Collaborator Author

/format

@slangbot
Copy link
Contributor

slangbot commented Feb 5, 2025

🌈 Formatted, please merge the changes from this PR

@slangbot slangbot mentioned this pull request Feb 5, 2025
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@csyonghe csyonghe Awaiting requested review from csyonghe

At least 1 approving review is required to merge this pull request.

Assignees

@jkwak-work jkwak-work

Labels
pr: non-breaking PRs without breaking changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jkwak-work @slangbot