fix: resolve compile drift and dead code in admin, storage, test_boun… - #331
Merged
Merged
Conversation
…daries, test_features Closes shakurJJ#214 — test_boundaries.rs: update all create_shipment calls from the old positional API (&buyer, ..., &false, &holdback) to the current ShipmentOptions struct API (&buyers_vec, ..., &ShipmentOptions{...}). Added default_opts() and buyers() helpers. mod test_boundaries; was already uncommented; tests now compile and pass against current struct/enum shapes. Closes shakurJJ#216 — test_features.rs: uncomment mod test_features; in lib.rs and expand default_opts() to include all ShipmentOptions fields added since the original draft (milestone_splits, deadlines, dispute_timeout_seconds, default_resolution, backup_arbiter, confirmation_cooldown_ledgers, arbiter_panel). The single_buyer() helper and ShipmentOptions spread syntax were already correct. Closes shakurJJ#219 — admin.rs: delete dead file. No mod admin; declaration existed so the file was never compiled. All admin functions (init, pause, upgrade, multisig, fee config, blacklist, arbiter fee tiers, emergency recovery, etc.) already live in lib.rs. Wiring admin.rs in would have produced E0201 duplicate-definition errors due to duplicate #[contractimpl] method names; deletion is the correct fix. Closes shakurJJ#220 — storage.rs: mod storage; is already declared and active in lib.rs. storage::get_arbiter_stats / set_arbiter_stats are called from lib.rs; the module IS the wired storage abstraction layer. Added a comprehensive module-level doc comment explaining the versioned-key design, TTL strategy, and migration path so the file's purpose is unambiguous.
|
@k-deejah Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…daries, test_features
Closes #214 — test_boundaries.rs: update all create_shipment calls from the old positional API (&buyer, ..., &false, &holdback) to the current ShipmentOptions struct API (&buyers_vec, ..., &ShipmentOptions{...}). Added default_opts() and buyers() helpers. mod test_boundaries; was already uncommented; tests now compile and pass against current struct/enum shapes.
Closes #216 — test_features.rs: uncomment mod test_features; in lib.rs and expand default_opts() to include all ShipmentOptions fields added since the original draft (milestone_splits, deadlines, dispute_timeout_seconds, default_resolution, backup_arbiter, confirmation_cooldown_ledgers, arbiter_panel). The single_buyer() helper and ShipmentOptions spread syntax were already correct.
Closes #219 — admin.rs: delete dead file. No mod admin; declaration existed so the file was never compiled. All admin functions (init, pause, upgrade, multisig, fee config, blacklist, arbiter fee tiers, emergency recovery, etc.) already live in lib.rs. Wiring admin.rs in would have produced E0201 duplicate-definition errors due to duplicate #[contractimpl] method names; deletion is the correct fix.
Closes #220 — storage.rs: mod storage; is already declared and active in lib.rs. storage::get_arbiter_stats / set_arbiter_stats are called from lib.rs; the module IS the wired storage abstraction layer. Added a comprehensive module-level doc comment explaining the versioned-key design, TTL strategy, and migration path so the file's purpose is unambiguous.