feat: enrich transaction history with known transaction data#216
Draft
premiumjibles wants to merge 3 commits intomainfrom
Draft
feat: enrich transaction history with known transaction data#216premiumjibles wants to merge 3 commits intomainfrom
premiumjibles wants to merge 3 commits intomainfrom
Conversation
Swaps are misclassified as "contract interactions" when Unchained returns incomplete tokenTransfers data. Fix by sending a lightweight known transactions map from the client (built from persistedTransactions) and enriching misclassified contract txs before filtering. Also parse internalTxs from Unchained to classify swaps where native ETH is transferred via internal calls rather than top-level tx.value. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Organization UI Review profile: CHILL Plan: Pro Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
📝 Coding Plan
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Remove .default() from schema fields that caused LLMs to echo unnecessary parameters. Rewrite types description as positive directive with mapping. Simplify renderTransactions to number-only type. Cap default context at 25 transactions. Move examples from system prompt into tool description. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Add 6 new transaction types (limitOrder, stopLoss, twap, deposit, withdraw, approval) and extract knownTransactions logic from ChatProvider into a chatStore selector that covers all 9 tool types including approval/deposit sub-transactions. Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
premiumjibles
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
limitOrder,stopLoss,twap,deposit,withdraw,approval) across the types package, server enrichment, and chat UIgetKnownTransactions()selector: Moves inlineknownTransactionsbuilder fromChatProvider.tsxintochatStore.ts, covering all 9 transaction-producing tools (swap, swapUsd, send, limitOrder, stopLoss, twap, vaultDeposit, vaultWithdraw, vaultWithdrawAll) with proper sub-transaction handling (approval/deposit sub-txs)ScrollTextfor orders,Vaultfor deposits/withdrawals,ShieldCheckfor approvals), label map, and grouped render logic (isSwapLike,isSendLike,isReceiveLike,isContractLike)Test plan
bun run lint— passesbun run type-check— passes (discriminated union expanded across all consumers)bun test— 828 tests, 0 failures (15 enrichment tests including 8 new ones for new types)🤖 Generated with Claude Code