fix: starknetjs version by gomesalexandre · Pull Request #776 · shapeshift/hdwallet

gomesalexandre · 2025-12-26T14:39:37Z

Description

Wrong version is used and seemed to be happy in web fren but web was failing CI re: missing l1_gas_data.
After we correctly pass it in web, signatures become borked (both signAndBroadcastTransaction and deployAccount).

The reason is signature is indeed wrong:

v6 hashFeeField() hashes with [tip, L1_GAS, L2_GAS] -> correct and works if we don't pass an l1_gas_data (but we need to to comply to spec, even though it works without) but breaks with it https://github.com/starknet-io/starknet.js/blob/v6.24.1/src/utils/hash/transactionHash/v3.ts#L53-L57
v9 hashFeeFieldV3B3() hashes with [tip, L1_GAS, L2_GAS, L1_DATA_GAS] -> bingo, we want this. https://github.com/starknet-io/starknet.js/blob/v9.3.0/src/utils/hash/transactionHash/v3.ts#L63-L68

Issue (if applicable)

closes N/A

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

None, blatant mistake

Testing

Test with web fren
Confirm signing / deploy happy for Starknet

Engineering

^

Operations

🏁 My feature is behind a flag and doesn't require operations testing (yet)

^

Screenshots (if applicable)

Summary by CodeRabbit

Chores
- Incremental patch release updating version from 1.62.33 to 1.62.34 across all wallet modules
- Aligned internal dependency versions for compatibility
- Updated Starknet support dependency to latest compatible version

_{✏️ Tip: You can customize this high-level summary in your review settings.}

Starknet network now requires l1_data_gas in transaction hash calculation. starknet.js v6.x hashFeeField: [tip, L1_GAS, L2_GAS] - missing l1_data_gas starknet.js v9.x hashFeeFieldV3B3: [tip, L1_GAS, L2_GAS, L1_DATA_GAS] This fixes "Account: invalid signature" errors when signing transactions. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

Reverts all package versions back to 1.62.33 (origin/master). Only preserves the starknet.js upgrade to v9.3.0 in hdwallet-native. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

vercel · 2025-12-26T14:39:42Z

The latest updates on your projects. Learn more about Vercel for GitHub.

Project	Deployment	Review	Updated (UTC)
hdwallet	Ready	Preview, Comment	Dec 26, 2025 2:46pm

coderabbitai · 2025-12-26T14:39:43Z

📝 Walkthrough

Walkthrough

A coordinated version bump from 1.62.33 to 1.62.34 across the monorepo, including lerna.json root configuration and all package.json files in examples, integration, and packages directories. The starknet dependency in hdwallet-native is also updated from ^6.11.0 to ^9.3.0.

Changes

Cohort / File(s)	Summary
Root configuration `lerna.json`	Version updated from 1.62.33 to 1.62.34
Example and integration packages `examples/sandbox/package.json`, `integration/package.json`	Version and 19 `@shapeshiftoss/hdwallet-`* dependencies bumped from 1.62.33 to 1.62.34
Core package `packages/hdwallet-core/package.json`	Version bumped from 1.62.33 to 1.62.34
Wallet adapter packages `packages/hdwallet-coinbase/package.json`, `packages/hdwallet-gridplus/package.json`, `packages/hdwallet-keplr/package.json`, `packages/hdwallet-phantom/package.json`, `packages/hdwallet-portis/package.json`, `packages/hdwallet-vultisig/package.json`, `packages/hdwallet-walletconnect/package.json`, `packages/hdwallet-walletconnectV2/package.json`, `packages/hdwallet-metamask-multichain/package.json`	Version and `@shapeshiftoss/hdwallet-core` dependency updated to 1.62.34
KeepKey adapter packages `packages/hdwallet-keepkey/package.json`, `packages/hdwallet-keepkey-chromeusb/package.json`, `packages/hdwallet-keepkey-electron/package.json`, `packages/hdwallet-keepkey-nodehid/package.json`, `packages/hdwallet-keepkey-nodewebusb/package.json`, `packages/hdwallet-keepkey-tcp/package.json`, `packages/hdwallet-keepkey-webusb/package.json`	Version bumped to 1.62.34; dependent hdwallet packages (`@shapeshiftoss/hdwallet-core`, `@shapeshiftoss/hdwallet-keepkey`) updated to 1.62.34
Ledger adapter packages `packages/hdwallet-ledger/package.json`, `packages/hdwallet-ledger-webhid/package.json`, `packages/hdwallet-ledger-webusb/package.json`	Version and `@shapeshiftoss/hdwallet-core` dependency updated to 1.62.34; webhid and webusb variants also update `@shapeshiftoss/hdwallet-ledger` to 1.62.34
Trezor adapter packages `packages/hdwallet-trezor/package.json`, `packages/hdwallet-trezor-connect/package.json`	Version and `@shapeshiftoss/hdwallet-core` dependency updated to 1.62.34; trezor-connect additionally updates `@shapeshiftoss/hdwallet-trezor` to 1.62.34
Native vault package `packages/hdwallet-native-vault/package.json`	Version bumped to 1.62.34; `@shapeshiftoss/hdwallet-native` dependency updated to 1.62.34
Native package `packages/hdwallet-native/package.json`	Version bumped to 1.62.34; `@shapeshiftoss/hdwallet-core` updated to 1.62.34; starknet dependency updated from ^6.11.0 to ^9.3.0

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

fix: hdwallet ci #738: Coordinated version bump across the same monorepo package manifests and hdwallet dependencies.
chore(release): publish 1.62.21 #757: Release/version-bump commit modifying the same package.json versions and hdwallet dependency fields across the repository.
fix: vercel ci #775: Updates examples/sandbox/package.json and related hdwallet package dependencies.

Suggested reviewers

NeOMakinG
kaladinlight

Poem

🐰 From one-six-two to three-four we hop,
Each package bumped, version won't stop!
Starknet leaps high—nine-point-three bright,
Dependencies dance in the moonlit night! 🌙✨

Pre-merge checks and finishing touches

❌ Failed checks (1 warning)

Check name	Status	Explanation	Resolution
Title check	⚠️ Warning	The title 'fix: starknetjs version' addresses the starknet.js upgrade to v9.3.0, but obscures the main purpose—fixing transaction signature hashing with L1_DATA_GAS. The PR also includes many unrelated package version bumps (1.62.33→1.62.34) across 20+ packages, making the title partially related but not reflective of the changeset scope.	Consider a more descriptive title like 'fix: upgrade starknetjs to v9.3.0 and bump package versions to 1.62.34' to better reflect both the core fix and the scope of version updates.

✅ Passed checks (2 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.

✨ Finishing touches

🧪 Generate unit tests (beta)

Create PR with unit tests
Post copyable unit tests in a comment
Commit unit tests in branch fix_starknet_ver

📜 Recent review details

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 25a11fb and 6677972.

⛔ Files ignored due to path filters (1)

yarn.lock is excluded by !**/yarn.lock, !**/*.lock

📒 Files selected for processing (27)

examples/sandbox/package.json
integration/package.json
lerna.json
packages/hdwallet-coinbase/package.json
packages/hdwallet-core/package.json
packages/hdwallet-gridplus/package.json
packages/hdwallet-keepkey-chromeusb/package.json
packages/hdwallet-keepkey-electron/package.json
packages/hdwallet-keepkey-nodehid/package.json
packages/hdwallet-keepkey-nodewebusb/package.json
packages/hdwallet-keepkey-tcp/package.json
packages/hdwallet-keepkey-webusb/package.json
packages/hdwallet-keepkey/package.json
packages/hdwallet-keplr/package.json
packages/hdwallet-ledger-webhid/package.json
packages/hdwallet-ledger-webusb/package.json
packages/hdwallet-ledger/package.json
packages/hdwallet-metamask-multichain/package.json
packages/hdwallet-native-vault/package.json
packages/hdwallet-native/package.json
packages/hdwallet-phantom/package.json
packages/hdwallet-portis/package.json
packages/hdwallet-trezor-connect/package.json
packages/hdwallet-trezor/package.json
packages/hdwallet-vultisig/package.json
packages/hdwallet-walletconnect/package.json
packages/hdwallet-walletconnectV2/package.json

🧰 Additional context used

🧠 Learnings (9)

📓 Common learnings

Learnt from: gomesalexandre
Repo: shapeshift/hdwallet PR: 726
File: packages/hdwallet-coinbase/package.json:18-18
Timestamp: 2025-08-07T15:23:54.858Z
Learning: In the shapeshiftoss/hdwallet monorepo, package version bumps are done in PRs before publishing. The packages are published after the PR is merged, so dependency versions may reference unpublished versions during the PR review phase. This is expected behavior in their release workflow.

Learnt from: gomesalexandre
Repo: shapeshift/hdwallet PR: 737
File: packages/hdwallet-trezor/src/ethereum.ts:122-138
Timestamp: 2025-11-20T11:04:44.808Z
Learning: In packages/hdwallet-trezor/src/ethereum.ts, the ethSignTypedData function correctly returns the signature from res.payload.signature without adding a "0x" prefix. This works correctly in practice and has been tested, despite appearing inconsistent with ethSignMessage which does add the prefix. The Trezor Connect ethereumSignTypedData response already provides the signature in the correct format for consumption.

Learnt from: gomesalexandre
Repo: shapeshift/hdwallet PR: 726
File: packages/hdwallet-ledger/package.json:36-36
Timestamp: 2025-08-07T15:27:03.179Z
Learning: In the shapeshiftoss/hdwallet monorepo, the ledgerhq/hw-transport dependency in packages/hdwallet-ledger/package.json is pinned to an exact version (without caret) due to type mismatches that occur with newer versions. Other Ledger dependencies can safely use caret ranges.

Learnt from: gomesalexandre
Repo: shapeshift/hdwallet PR: 726
File: packages/hdwallet-ledger-webusb/package.json:3-3
Timestamp: 2025-08-07T15:24:19.530Z
Learning: In the shapeshiftoss/hdwallet monorepo, the team runs `yarn build` before bumping versions and also before publishing packages. This ensures that dist/ artifacts (including UMD bundles) are properly regenerated after dependency updates.

📚 Learning: 2025-08-07T15:27:03.179Z

Learnt from: gomesalexandre
Repo: shapeshift/hdwallet PR: 726
File: packages/hdwallet-ledger/package.json:36-36
Timestamp: 2025-08-07T15:27:03.179Z
Learning: In the shapeshiftoss/hdwallet monorepo, the ledgerhq/hw-transport dependency in packages/hdwallet-ledger/package.json is pinned to an exact version (without caret) due to type mismatches that occur with newer versions. Other Ledger dependencies can safely use caret ranges.

Applied to files:

packages/hdwallet-keepkey-webusb/package.json
packages/hdwallet-phantom/package.json
packages/hdwallet-keplr/package.json
packages/hdwallet-keepkey-electron/package.json
packages/hdwallet-trezor/package.json
packages/hdwallet-keepkey-tcp/package.json
packages/hdwallet-keepkey/package.json
packages/hdwallet-walletconnect/package.json
packages/hdwallet-trezor-connect/package.json
packages/hdwallet-native/package.json
packages/hdwallet-ledger/package.json
packages/hdwallet-walletconnectV2/package.json
packages/hdwallet-core/package.json
packages/hdwallet-coinbase/package.json
packages/hdwallet-keepkey-chromeusb/package.json
packages/hdwallet-ledger-webusb/package.json
packages/hdwallet-ledger-webhid/package.json
packages/hdwallet-native-vault/package.json
packages/hdwallet-keepkey-nodewebusb/package.json
packages/hdwallet-metamask-multichain/package.json
packages/hdwallet-portis/package.json
packages/hdwallet-gridplus/package.json
examples/sandbox/package.json
integration/package.json
packages/hdwallet-keepkey-nodehid/package.json
packages/hdwallet-vultisig/package.json

📚 Learning: 2025-08-07T15:23:54.858Z

Learnt from: gomesalexandre
Repo: shapeshift/hdwallet PR: 726
File: packages/hdwallet-coinbase/package.json:18-18
Timestamp: 2025-08-07T15:23:54.858Z
Learning: In the shapeshiftoss/hdwallet monorepo, package version bumps are done in PRs before publishing. The packages are published after the PR is merged, so dependency versions may reference unpublished versions during the PR review phase. This is expected behavior in their release workflow.

Applied to files:

packages/hdwallet-keepkey-webusb/package.json
packages/hdwallet-phantom/package.json
packages/hdwallet-keplr/package.json
packages/hdwallet-keepkey-electron/package.json
packages/hdwallet-trezor/package.json
packages/hdwallet-keepkey-tcp/package.json
packages/hdwallet-keepkey/package.json
packages/hdwallet-walletconnect/package.json
packages/hdwallet-trezor-connect/package.json
packages/hdwallet-native/package.json
packages/hdwallet-ledger/package.json
packages/hdwallet-walletconnectV2/package.json
packages/hdwallet-core/package.json
packages/hdwallet-coinbase/package.json
packages/hdwallet-keepkey-chromeusb/package.json
packages/hdwallet-ledger-webusb/package.json
packages/hdwallet-ledger-webhid/package.json
packages/hdwallet-native-vault/package.json
packages/hdwallet-keepkey-nodewebusb/package.json
packages/hdwallet-metamask-multichain/package.json
packages/hdwallet-portis/package.json
packages/hdwallet-gridplus/package.json
examples/sandbox/package.json
integration/package.json
packages/hdwallet-keepkey-nodehid/package.json
packages/hdwallet-vultisig/package.json

📚 Learning: 2025-08-07T15:24:19.530Z

Learnt from: gomesalexandre
Repo: shapeshift/hdwallet PR: 726
File: packages/hdwallet-ledger-webusb/package.json:3-3
Timestamp: 2025-08-07T15:24:19.530Z
Learning: In the shapeshiftoss/hdwallet monorepo, the team runs `yarn build` before bumping versions and also before publishing packages. This ensures that dist/ artifacts (including UMD bundles) are properly regenerated after dependency updates.

Applied to files:

packages/hdwallet-keepkey-webusb/package.json
packages/hdwallet-phantom/package.json
packages/hdwallet-keplr/package.json
packages/hdwallet-keepkey-electron/package.json
packages/hdwallet-trezor/package.json
packages/hdwallet-keepkey-tcp/package.json
packages/hdwallet-keepkey/package.json
packages/hdwallet-walletconnect/package.json
packages/hdwallet-trezor-connect/package.json
packages/hdwallet-native/package.json
packages/hdwallet-ledger/package.json
packages/hdwallet-walletconnectV2/package.json
packages/hdwallet-core/package.json
packages/hdwallet-coinbase/package.json
packages/hdwallet-keepkey-chromeusb/package.json
packages/hdwallet-ledger-webusb/package.json
packages/hdwallet-ledger-webhid/package.json
packages/hdwallet-native-vault/package.json
packages/hdwallet-keepkey-nodewebusb/package.json
packages/hdwallet-metamask-multichain/package.json
packages/hdwallet-portis/package.json
packages/hdwallet-gridplus/package.json
examples/sandbox/package.json
integration/package.json
packages/hdwallet-keepkey-nodehid/package.json
packages/hdwallet-vultisig/package.json

📚 Learning: 2025-12-09T13:48:55.139Z

Learnt from: gomesalexandre
Repo: shapeshift/hdwallet PR: 764
File: packages/hdwallet-gridplus/package.json:0-0
Timestamp: 2025-12-09T13:48:55.139Z
Learning: In the shapeshiftoss/hdwallet monorepo, the dist/ directory is not version controlled (not tracked in git). Build artifacts are generated during the build/publish workflow, not committed to the repository.

Applied to files:

packages/hdwallet-keepkey-webusb/package.json
packages/hdwallet-phantom/package.json
packages/hdwallet-keplr/package.json
packages/hdwallet-keepkey-electron/package.json
packages/hdwallet-trezor/package.json
packages/hdwallet-keepkey-tcp/package.json
packages/hdwallet-keepkey/package.json
packages/hdwallet-walletconnect/package.json
packages/hdwallet-trezor-connect/package.json
packages/hdwallet-native/package.json
packages/hdwallet-ledger/package.json
packages/hdwallet-walletconnectV2/package.json
packages/hdwallet-core/package.json
packages/hdwallet-coinbase/package.json
packages/hdwallet-keepkey-chromeusb/package.json
packages/hdwallet-ledger-webusb/package.json
packages/hdwallet-ledger-webhid/package.json
packages/hdwallet-native-vault/package.json
packages/hdwallet-keepkey-nodewebusb/package.json
packages/hdwallet-metamask-multichain/package.json
packages/hdwallet-portis/package.json
packages/hdwallet-gridplus/package.json
examples/sandbox/package.json
integration/package.json
packages/hdwallet-keepkey-nodehid/package.json
packages/hdwallet-vultisig/package.json

📚 Learning: 2025-08-07T15:47:29.207Z

Learnt from: gomesalexandre
Repo: shapeshift/hdwallet PR: 726
File: packages/hdwallet-ledger/src/transport.ts:10-10
Timestamp: 2025-08-07T15:47:29.207Z
Learning: In the shapeshiftoss/hdwallet monorepo, ts-ignore is used instead of ts-expect-error for Ledger transport imports because the code works locally without TypeScript errors but has issues in CI environment. Using ts-expect-error would fail locally since there are no actual errors to suppress.

Applied to files:

packages/hdwallet-keepkey-webusb/package.json
packages/hdwallet-phantom/package.json
packages/hdwallet-keplr/package.json
packages/hdwallet-keepkey-electron/package.json
packages/hdwallet-trezor/package.json
packages/hdwallet-keepkey-tcp/package.json
packages/hdwallet-keepkey/package.json
packages/hdwallet-walletconnect/package.json
packages/hdwallet-trezor-connect/package.json
packages/hdwallet-native/package.json
packages/hdwallet-ledger/package.json
packages/hdwallet-walletconnectV2/package.json
packages/hdwallet-coinbase/package.json
packages/hdwallet-keepkey-chromeusb/package.json
packages/hdwallet-ledger-webusb/package.json
packages/hdwallet-ledger-webhid/package.json
packages/hdwallet-native-vault/package.json
packages/hdwallet-keepkey-nodewebusb/package.json
packages/hdwallet-metamask-multichain/package.json
packages/hdwallet-portis/package.json
packages/hdwallet-gridplus/package.json
examples/sandbox/package.json
integration/package.json
packages/hdwallet-keepkey-nodehid/package.json
packages/hdwallet-vultisig/package.json

📚 Learning: 2025-08-07T15:47:26.835Z

Learnt from: gomesalexandre
Repo: shapeshift/hdwallet PR: 726
File: packages/hdwallet-ledger-webusb/src/transport.ts:12-12
Timestamp: 2025-08-07T15:47:26.835Z
Learning: In the shapeshiftoss/hdwallet monorepo, ts-ignore is used instead of ts-expect-error for Ledger transport imports because the CI environment has different type checking behavior than local development. The code works locally without errors, but CI reports type issues, so ts-ignore is necessary to suppress the inconsistent type checking across environments.

Applied to files:

packages/hdwallet-keepkey-webusb/package.json
packages/hdwallet-keplr/package.json
packages/hdwallet-keepkey-electron/package.json
packages/hdwallet-trezor/package.json
packages/hdwallet-keepkey-tcp/package.json
packages/hdwallet-keepkey/package.json
packages/hdwallet-walletconnect/package.json
packages/hdwallet-trezor-connect/package.json
packages/hdwallet-native/package.json
packages/hdwallet-ledger/package.json
packages/hdwallet-walletconnectV2/package.json
packages/hdwallet-coinbase/package.json
packages/hdwallet-keepkey-chromeusb/package.json
packages/hdwallet-ledger-webusb/package.json
packages/hdwallet-ledger-webhid/package.json
packages/hdwallet-native-vault/package.json
packages/hdwallet-keepkey-nodewebusb/package.json
packages/hdwallet-metamask-multichain/package.json
packages/hdwallet-portis/package.json
packages/hdwallet-gridplus/package.json
examples/sandbox/package.json
integration/package.json
packages/hdwallet-keepkey-nodehid/package.json
packages/hdwallet-vultisig/package.json

📚 Learning: 2025-12-12T11:20:00.907Z

Learnt from: gomesalexandre
Repo: shapeshift/hdwallet PR: 769
File: packages/hdwallet-walletconnectV2/src/walletconnectV2.ts:150-152
Timestamp: 2025-12-12T11:20:00.907Z
Learning: In the shapeshift/hdwallet monorepo, the `ethSupportsNetwork()` method in wallet implementations is a legacy/relic method that is no longer used. Chain support is determined by the `_supports*` flags (e.g., `_supportsMonad`, `_supportsPlasma`, `_supportsHyperEvm`) on the wallet classes, not by the `ethSupportsNetwork()` method.

Applied to files:

packages/hdwallet-trezor/package.json
packages/hdwallet-coinbase/package.json

📚 Learning: 2025-08-07T15:24:34.076Z

Learnt from: gomesalexandre
Repo: shapeshift/hdwallet PR: 726
File: examples/sandbox/package.json:15-31
Timestamp: 2025-08-07T15:24:34.076Z
Learning: Lerna v6+ supports workspace protocol syntax (workspace:*) but does not automatically convert exact versions to workspace protocol during version bumps. It only preserves existing workspace protocol syntax. Teams using Lerna for automated version bumps would need manual conversion to use workspace protocol, which negates automation benefits.

Applied to files:

lerna.json

⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)

GitHub Check: Build and Release

🔇 Additional comments (28)

lerna.json (1)

3-3: LGTM! Coordinated version bump to 1.62.34.

The lerna configuration version is correctly updated as part of the monorepo-wide release.

packages/hdwallet-coinbase/package.json (1)

3-3: LGTM! Version and dependency updates are consistent.

The package version and hdwallet-core dependency are correctly aligned to 1.62.34.

Also applies to: 18-18

packages/hdwallet-phantom/package.json (1)

3-3: LGTM! Version and dependency updates are consistent.

The package version and hdwallet-core dependency are correctly aligned to 1.62.34.

Also applies to: 18-18

packages/hdwallet-native-vault/package.json (1)

3-3: LGTM! Version and dependency updates are consistent.

The package version and hdwallet-native dependency are correctly aligned to 1.62.34.

Also applies to: 18-18

packages/hdwallet-walletconnectV2/package.json (1)

3-3: LGTM! Version and dependency updates are consistent.

The package version and hdwallet-core dependency are correctly aligned to 1.62.34.

Also applies to: 18-18

packages/hdwallet-trezor/package.json (1)

3-3: LGTM! Version and dependency updates are consistent.

The package version and hdwallet-core dependency are correctly aligned to 1.62.34.

Also applies to: 20-20

packages/hdwallet-portis/package.json (1)

3-3: LGTM! Version and dependency updates are consistent.

The package version and hdwallet-core dependency are correctly aligned to 1.62.34.

Also applies to: 19-19

packages/hdwallet-metamask-multichain/package.json (1)

3-3: LGTM! Version and dependency updates are consistent.

The package version and hdwallet-core dependency are correctly aligned to 1.62.34.

Also applies to: 20-20

packages/hdwallet-vultisig/package.json (1)

3-3: LGTM! Routine version bump aligned with monorepo release.

The package version and hdwallet-core dependency are correctly updated to 1.62.34, consistent with the coordinated release.

Also applies to: 20-20

packages/hdwallet-keplr/package.json (1)

3-3: LGTM! Version alignment looks correct.

Package and core dependency versions properly synchronized to 1.62.34.

Also applies to: 20-20

packages/hdwallet-ledger-webusb/package.json (1)

3-3: LGTM! Coordinated version update across WebUSB transport.

Package version and both internal dependencies (core and ledger) correctly bumped to 1.62.34. External Ledger dependencies remain stable.

Also applies to: 23-24

packages/hdwallet-ledger-webhid/package.json (1)

3-3: LGTM! WebHID transport version synchronized.

Package and internal dependencies (core and ledger) properly aligned to 1.62.34.

Also applies to: 21-22

packages/hdwallet-core/package.json (1)

3-3: LGTM! Core package version updated.

The core package version bump to 1.62.34 is correct and will be consumed by all dependent packages across the monorepo.

packages/hdwallet-walletconnect/package.json (1)

3-3: LGTM! WalletConnect package aligned with release.

Package version and core dependency correctly updated to 1.62.34.

Also applies to: 18-18

packages/hdwallet-keepkey-electron/package.json (1)

3-3: LGTM! KeepKey Electron package synchronized.

Package version and keepkey dependency properly updated to 1.62.34.

Also applies to: 17-17

packages/hdwallet-ledger/package.json (1)

3-3: LGTM! Ledger base package version aligned.

Package version and core dependency correctly synchronized to 1.62.34. All external Ledger dependencies remain stable.

Also applies to: 31-31

packages/hdwallet-keepkey/package.json (1)

3-3: LGTM! Coordinated version bump to 1.62.34.

The package and dependency versions are correctly aligned with the monorepo-wide version bump.

Also applies to: 24-24

packages/hdwallet-keepkey-tcp/package.json (1)

3-3: LGTM! Coordinated version bump to 1.62.34.

Package and dependency versions are correctly synchronized with the monorepo release.

Also applies to: 17-18

packages/hdwallet-keepkey-webusb/package.json (1)

3-3: LGTM! Coordinated version bump to 1.62.34.

Version alignment is correct across package and dependencies.

Also applies to: 17-18

packages/hdwallet-gridplus/package.json (1)

3-3: LGTM! Coordinated version bump to 1.62.34.

Package and dependency versions properly aligned with the monorepo release.

Also applies to: 23-23

packages/hdwallet-keepkey-nodehid/package.json (1)

3-3: LGTM! Coordinated version bump to 1.62.34.

Version alignment is correct.

Also applies to: 17-17

packages/hdwallet-native/package.json (2)

3-3: LGTM! Coordinated version bump to 1.62.34.

Package and core dependency versions correctly aligned.

Also applies to: 21-21

42-42: Clarify the use of starknet v9.3.0, which is tagged as "next" rather than "latest" stable.

Version 9.3.0 exists on npm but is not the stable release (latest is 9.2.1). The "next" dist-tag indicates this is a pre-release or upcoming version. Using ^9.3.0 in production dependencies means accepting any version >=9.3.0, which could introduce unstable releases. Consider whether 9.2.1 (the current stable) addresses the L1_DATA_GAS issue, or document why the "next" version is necessary for this fix.

packages/hdwallet-trezor-connect/package.json (1)

3-3: LGTM! Coordinated version bump to 1.62.34.

Version synchronization is correct across package and dependencies.

Also applies to: 17-18

packages/hdwallet-keepkey-chromeusb/package.json (1)

3-3: LGTM! Coordinated version bump to 1.62.34.

Package and dependency versions correctly aligned with the monorepo release.

Also applies to: 17-18

packages/hdwallet-keepkey-nodewebusb/package.json (1)

3-3: LGTM! Version bump is consistent across package and dependencies.

The version bump to 1.62.34 is properly coordinated with the internal dependencies.

Also applies to: 17-18

examples/sandbox/package.json (1)

3-3: LGTM! Coordinated version bump across all internal dependencies.

All 19 internal @shapeshiftoss/hdwallet-* dependencies are consistently updated to 1.62.34 along with the package version.

Also applies to: 15-33

integration/package.json (1)

3-3: LGTM! Version alignment is correct.

The package version and all 10 internal @shapeshiftoss/hdwallet-* dependencies are consistently updated to 1.62.34.

Also applies to: 15-24

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

gomesalexandre and others added 6 commits December 26, 2025 14:37

chore: version packages to 1.62.34-starknet-debug.0

a0ce0f1

chore: version packages to 1.62.34-starknet-debug.1 (starknet v9)

c549d5c

chore: remove debug logging from starknet implementation

e48ec1b

chore: update yarn.lock for starknet.js v9.3.0

3540ce1

🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude Opus 4.5 <noreply@anthropic.com>

gomesalexandre marked this pull request as ready for review December 26, 2025 14:41

gomesalexandre requested a review from a team as a code owner December 26, 2025 14:41

chore(release): publish 1.62.34

6677972

vercel bot deployed to Preview December 26, 2025 14:46 View deployment

gomesalexandre merged commit 4f5859c into master Dec 26, 2025
5 checks passed

gomesalexandre deleted the fix_starknet_ver branch December 26, 2025 14:55

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fix: starknetjs version#776

fix: starknetjs version#776
gomesalexandre merged 7 commits intomasterfrom
fix_starknet_ver

gomesalexandre commented Dec 26, 2025 •

edited by coderabbitai bot

Loading

Uh oh!

vercel bot commented Dec 26, 2025 •

edited

Loading

Uh oh!

coderabbitai bot commented Dec 26, 2025 •

edited

Loading

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Conversation

gomesalexandre commented Dec 26, 2025 • edited by coderabbitai bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Issue (if applicable)

Risk

Testing

Engineering

Operations

Screenshots (if applicable)

Summary by CodeRabbit

Uh oh!

vercel bot commented Dec 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

coderabbitai bot commented Dec 26, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Estimated code review effort

Possibly related PRs

Suggested reviewers

Poem

Pre-merge checks and finishing touches

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

gomesalexandre commented Dec 26, 2025 •

edited by coderabbitai bot

Loading

vercel bot commented Dec 26, 2025 •

edited

Loading

coderabbitai bot commented Dec 26, 2025 •

edited

Loading