Skip to content

fix: popular asset fixes for second-class chains#11421

Merged
NeOMakinG merged 2 commits intodevelopfrom
feat_second_class_chains_popular_assets
Dec 16, 2025
Merged

fix: popular asset fixes for second-class chains#11421
NeOMakinG merged 2 commits intodevelopfrom
feat_second_class_chains_popular_assets

Conversation

@gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Dec 16, 2025

Description

Two birds one stone:

  1. Add missing second-class chains in asset chain selection
  2. Add missing native assets for second class chains in asset selection

Issue (if applicable)

closes N/A, spotted in release

Risk

High Risk PRs Require 2 approvals

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

Low, under flag and blatant omission

Testing

  • All second-class chains appear under chain selection assuming flag on
  • With a wallet that doesn't support said chain (e.g MM), native assets are visible under popuular assets when filtering by second-class chain

Engineering

  • ^

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)
  • ^

Screenshots (if applicable)

Screenshot 2025-12-16 at 02 54 06 Screenshot 2025-12-16 at 02 54 27 Screenshot 2025-12-16 at 02 55 15 Screenshot 2025-12-16 at 03 08 34 Screenshot 2025-12-16 at 03 08 40 Screenshot 2025-12-16 at 03 08 50

Summary by CodeRabbit

  • New Features

    • Expanded popular assets list to surface native assets from additional blockchains (HyperEVM, Monad, Plasma, Sui, Tron), improving discoverability when filtering by chain and honoring feature flags.
  • Documentation

    • Added guidance on adding chain native assets to the popular assets list, including recommended feature-flag patterns and rationale for surfacing native assets beyond CoinGecko listings.

✏️ Tip: You can customize this high-level summary in your review settings.

@gomesalexandre gomesalexandre requested a review from a team as a code owner December 16, 2025 00:16
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 16, 2025

📝 Walkthrough

Walkthrough

Adds native asset IDs for HyperEVM, Monad, Plasma, Sui, and Tron to the popular-assets discovery path (feature-flag gated) and documents the integration pattern for second-class chains in SKILL.md.

Changes

Cohort / File(s) Summary
Documentation
\.claude/skills/chain-integration/SKILL.md
Adds Step 5.5: guidance and a TypeScript example showing how to add native asset IDs (hyperEvm, monad, plasma, sui, tron, etc.) to the Popular Assets list and explains CoinGecko top-100 limitations for second-class chains.
Implementation
src/components/TradeAssetSearch/hooks/useGetPopularAssetsQuery.tsx
Expands @shapeshiftoss/caip imports to include hyperEvmAssetId, monadAssetId, plasmaAssetId, suiAssetId, tronAssetId; conditionally pushes these asset IDs into assetIds when corresponding feature flags are enabled, following existing thorchain/mayachain patterns.

Estimated code review effort

🎯 2 (Simple) | ⏱️ ~8 minutes

  • Verify the listed asset IDs are exported from @shapeshiftoss/caip.
  • Confirm feature-flag names match the actual flags and are documented.
  • Check for duplicate insertion (file shows identical block twice in doc) and remove if unintended.

Possibly related PRs

Suggested reviewers

  • 0xApotheosis
  • premiumjibles

Poem

"🐰 I hopped through code to add five more,
Native coins knocking at discovery's door.
Flags set to true, they join the parade,
Little chains cheer — now not so delayed! ✨"

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title accurately describes the main change: adding native assets for second-class chains to popular assets selection, which is the core functionality implemented in the code changes.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat_second_class_chains_popular_assets

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

Disabled knowledge base sources:

  • Linear integration is disabled by default for public repositories

You can enable these sources in your CodeRabbit configuration.

📥 Commits

Reviewing files that changed from the base of the PR and between 6e0b563 and 5eba20e.

📒 Files selected for processing (1)
  • .claude/skills/chain-integration/SKILL.md (1 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • .claude/skills/chain-integration/SKILL.md
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (1)
  • GitHub Check: Call / Static

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Copy link
Collaborator

@NeOMakinG NeOMakinG left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@NeOMakinG NeOMakinG enabled auto-merge (squash) December 16, 2025 10:59
@NeOMakinG NeOMakinG merged commit f0c198a into develop Dec 16, 2025
4 checks passed
@NeOMakinG NeOMakinG deleted the feat_second_class_chains_popular_assets branch December 16, 2025 11:07
@coderabbitai coderabbitai bot mentioned this pull request Dec 26, 2025
1 task
@coderabbitai coderabbitai bot mentioned this pull request Jan 5, 2026
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants