Skip to content

feat: add Ledger app gate to Sui chain adapter #11450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gomesalexandre merged 3 commits into from
Dec 18, 2025
Merged

feat: add Ledger app gate to Sui chain adapter #11450

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
cbd704e
feat: add Ledger app gate to Sui chain adapter
gomesalexandre Dec 17, 2025
7c2a599
Merge branch 'develop' into capy/cap-7-424c7dc7
gomesalexandre Dec 18, 2025
7fb1635
Merge branch 'develop' into capy/cap-7-424c7dc7
gomesalexandre Dec 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion packages/chain-adapters/src/sui/SuiChainAdapter.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,7 +30,7 @@ import type {
ValidAddressResult,
} from '../types'
import { ChainAdapterDisplayName, ValidAddressResultType } from '../types'
import { toAddressNList } from '../utils'
import { toAddressNList, verifyLedgerAppOpen } from '../utils'

export interface ChainAdapterArgs {
rpcUrl: string
Expand Down Expand Up @@ -100,6 +100,8 @@ export class ChainAdapter implements IChainAdapter<KnownChainIds.SuiMainnet> {
if (!wallet) throw new Error('wallet is required')
this.assertSupportsChain(wallet)

await verifyLedgerAppOpen(this.chainId, wallet)

const address = await wallet.suiGetAddress({
addressNList: toAddressNList(this.getBip44Params({ accountNumber })),
showDisplay: showOnDevice,
Expand Down Expand Up @@ -320,6 +322,8 @@ export class ChainAdapter implements IChainAdapter<KnownChainIds.SuiMainnet> {
if (!wallet) throw new Error('wallet is required')
this.assertSupportsChain(wallet)

await verifyLedgerAppOpen(this.chainId, wallet)

const signedTx = await wallet.suiSignTx(txToSign)

if (!signedTx?.signature || !signedTx?.publicKey) {
Expand Down Expand Up @@ -349,6 +353,8 @@ export class ChainAdapter implements IChainAdapter<KnownChainIds.SuiMainnet> {
if (!wallet) throw new Error('wallet is required')
this.assertSupportsChain(wallet)

await verifyLedgerAppOpen(this.chainId, wallet)

const signedTx = await wallet.suiSignTx(txToSign)

if (!signedTx?.signature || !signedTx?.publicKey) {
Expand Down