Skip to content

fix: markets page ghost row #11498

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
gomesalexandre merged 8 commits into from
Dec 22, 2025
Merged

fix: markets page ghost row #11498

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
85f49f3
feat: monkey patch flags off
gomesalexandre Dec 19, 2025
af55bf5
fix: add ?url to SVG import to fix MIME type error
gomesalexandre Dec 18, 2025
136c41f
fix: prevent ghost rows in markets chain dropdown
gomesalexandre Dec 19, 2025
172c00c
chore: apply lint fixes to MarketsRow
gomesalexandre Dec 19, 2025
6402273
fix: filter disabled second-class chains from markets dropdown
gomesalexandre Dec 19, 2025
a5e012d
feat: revert flags monkey patch
gomesalexandre Dec 19, 2025
d76a282
Merge branch 'develop' into fix_markets_page_ghost_rows
gomesalexandre Dec 19, 2025
7178156
Merge branch 'develop' into fix_markets_page_ghost_rows
gomesalexandre Dec 22, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/components/Layout/Header/ActionCenter/components/AppUpdateActionCard.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ import { useTranslate } from 'react-polyglot'

import { ActionCard } from './ActionCard'

import UpdateIcon from '@/assets/update-icon.svg'
import UpdateIcon from '@/assets/update-icon.svg?url'
import { Text } from '@/components/Text/Text'
import { formatSmartDate } from '@/lib/utils/time'
import type { AppUpdateAction } from '@/state/slices/actionSlice/types'
Expand Down
21 changes: 13 additions & 8 deletions src/pages/Markets/components/MarketsRow.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,17 +80,22 @@ export const MarketsRow: React.FC<MarketsRowProps> = ({
(params.category && sortOptionsByCategory[params.category]?.[0]) ?? SortOptionsKeys.Volume,
)
const isArbitrumNovaEnabled = useAppSelector(state => selectFeatureFlag(state, 'ArbitrumNova'))
const isSuiEnabled = useAppSelector(state => selectFeatureFlag(state, 'Sui'))
const isPlasmaEnabled = useAppSelector(state => selectFeatureFlag(state, 'Plasma'))
const isHyperEvmEnabled = useAppSelector(state => selectFeatureFlag(state, 'HyperEvm'))
const [isSmallerThanLg] = useMediaQuery(`(max-width: ${breakpoints.lg})`)

const chainIds = useMemo(() => {
if (!supportedChainIds)
return Object.values(KnownChainIds).filter(chainId => {
if (!isArbitrumNovaEnabled && chainId === KnownChainIds.ArbitrumNovaMainnet) return false
return true
})

return supportedChainIds
}, [isArbitrumNovaEnabled, supportedChainIds])
const baseChainIds = supportedChainIds ?? Object.values(KnownChainIds)

return baseChainIds.filter(chainId => {
if (!isArbitrumNovaEnabled && chainId === KnownChainIds.ArbitrumNovaMainnet) return false
if (!isSuiEnabled && chainId === KnownChainIds.SuiMainnet) return false
if (!isPlasmaEnabled && chainId === KnownChainIds.PlasmaMainnet) return false
if (!isHyperEvmEnabled && chainId === KnownChainIds.HyperEvmMainnet) return false
return true
})
}, [supportedChainIds, isArbitrumNovaEnabled, isSuiEnabled, isPlasmaEnabled, isHyperEvmEnabled])

const Title = useMemo(() => {
if (!title) return null
Expand Down