Skip to content

feat: Sui Ledger blind signing detection#11507

Closed
gomesalexandre wants to merge 1 commit intodevelopfrom
feat_sui_blind_sign
Closed

feat: Sui Ledger blind signing detection#11507
gomesalexandre wants to merge 1 commit intodevelopfrom
feat_sui_blind_sign

Conversation

@gomesalexandre
Copy link
Contributor

@gomesalexandre gomesalexandre commented Dec 22, 2025

Description

Bumps hdwallet packages to pick up Sui Ledger blind signing detection.

Issue (if applicable)

closes #11489

Risk

What protocols, transaction types, wallets or contract interactions might be affected by this PR?

  • Wallets: Ledger hardware wallets with Sui support
  • Transaction Types: Sui transactions requiring blind signing
  • Risk Level: Low - dependency bump for error handling

Testing

Engineering

  • Ensure without blind signing enabled in Sui Ledger app, you see a toast error prompting you to enable it
  • Ensure Sui transactions work with blind signing enabled

Operations

  • 🏁 My feature is behind a flag and doesn't require operations testing (yet)

Screenshots (if applicable)

https://jam.dev/c/2bafcadd-be8d-4917-9c7d-936a5c97a257


web fren of shapeshift/hdwallet#773

feat: regenerate asset data 12/21/2025

Co-authored-by: asset-generation-bot <action@github.com>
@coderabbitai
Copy link
Contributor

coderabbitai bot commented Dec 22, 2025

Important

Review skipped

Draft detected.

Please check the settings in the CodeRabbit UI or the .coderabbit.yaml file in this repository. To trigger a single review, invoke the @coderabbitai review command.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

✨ Finishing touches
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch feat_sui_blind_sign

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@gomesalexandre gomesalexandre deleted the feat_sui_blind_sign branch December 22, 2025 11:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

SUI - blind signing error detection

1 participant