fix: yield correct symbol for approve rows + wait for on-chain complete before next tx

[gomesalexandre]

Description

Two targeted fixes for the yield transaction flow:

1. Show correct token in approval step labels — Approval steps on yield exit now show the actual receipt token being approved (rETH, stETH, sAVAX) instead of the native/underlying asset. Native assets like ETH/AVAX can't be ERC-20 approved — the approval always targets the receipt token contract. Confirmed via yield.xyz API responses:

   • rETH exit: APPROVAL tx targets 0xae78736C... (rETH contract) → "Approve rETH"
   • stETH exit: APPROVAL tx targets 0xae7ab965... (stETH contract) → "Approve stETH"

2. Wait for on-chain receipt between multi-step yield transactions — For EVM chains, the hook now waits for the on-chain transaction receipt before polling for the next transaction step. This prevents race conditions where the API hasn't yet confirmed the previous step.

Issue (if applicable)

Risk

Low — UI label change for approval steps only, plus a timing fix for multi-step tx flows. No changes to transaction amounts or contract interactions.

Yield exit flows for liquid staking tokens (rETH, stETH, sAVAX) and multi-step EVM yield transactions.

Testing

Engineering

1. yarn type-check passes
2. yarn lint passes
3. npx vitest run src/lib/yieldxyz/ — 99 tests pass
4. rETH exit: Approval step should say "Approve rETH" (not "Approve ETH")
5. stETH exit: Approval step should say "Approve stETH" (not "Approve ETH")
6. Multi-step yield tx (e.g. rETH exit with Approve + Swap): Second step should only start after first tx is confirmed on-chain

Operations

• Test rETH unstake — approval step shows "Approve rETH"
• Test stETH unstake — approval step shows "Approve stETH"
• Test multi-step yield transactions complete without errors

Screenshots (if applicable)

https://jam.dev/c/0345edfe-db55-4c71-91f3-d08296a08ce5
https://jam.dev/c/79d807e2-d5f5-4f57-a43d-418c77b97dea

Summary by CodeRabbit

Release Notes

• New Features

  • Transaction symbols now resolve dynamically based on transaction type and action phase (exit/enter/manage) for improved accuracy in UI displays.
  • Enhanced multi-step transaction handling with explicit chain namespace support.

• Tests

  • Added comprehensive test coverage for symbol resolution logic across multiple transaction scenarios and fallback cases.

[coderabbitai]

📝 Walkthrough

Walkthrough

A new utility function resolveAssetSymbolForTx determines which asset symbol to display for a transaction based on its type, action phase (enter/exit/manage), and available assets. The function is implemented in the utils module with comprehensive tests and integrated throughout the yield transaction flow hook for per-transaction symbol resolution.

Changes

Cohort / File(s)	Summary
Symbol Resolution Logic src/lib/yieldxyz/utils.ts, src/lib/yieldxyz/utils.test.ts	Introduced resolveAssetSymbolForTx function that selects asset symbols based on transaction type and action (returns output token for exit/APPROVAL operations, input token otherwise); added central assertNever helper; includes comprehensive test coverage for all symbol resolution scenarios and fallback behaviors.
Transaction Flow Integration src/pages/Yields/hooks/useYieldTransactionFlow.ts	Integrated resolveAssetSymbolForTx into transaction flow hook with local resolveSymbolForTx wrapper; replaced static assetSymbol with dynamic symbol resolution in transaction step titles and messages; added EVM chain namespace detection for transaction receipt waiting on multi-step flows; updated effect dependencies to reference the new resolution helper.

Estimated code review effort

🎯 3 (Moderate) | ⏱️ ~20 minutes

Possibly related PRs

• feat: yield liquid staking fixes and improvements #11782: Modifies the same files to add tx-type-based labeling and pass tx.type into title formatting, directly related to per-transaction symbol/label resolution approach.
• feat: yield improvements following CR #11729: Makes yield-type-aware title and label resolution in the same utilities and hook, implementing similar per-transaction asset resolution patterns.

Suggested reviewers

• NeOMakinG

Poem

🐰✨ A symbol springs forth, context-aware and bright,
Resolving assets for each transaction's plight,
Exit or enter, the chain knows the way,
Per-transaction wisdom guides the display! 🎯

🚥 Pre-merge checks | ✅ 3

✅ Passed checks (3 passed)

Check name	Status	Explanation
Description Check	✅ Passed	Check skipped - CodeRabbit’s high-level summary is enabled.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check.
Title check	✅ Passed	The title 'fix: yield correct symbol for approve rows + wait for on-chain complete before next tx' accurately and specifically summarizes both main changes: correcting approval symbol display and adding on-chain transaction confirmation waits.

_{✏️ Tip: You can configure your own custom pre-merge checks in the settings.}

✨ Finishing touches

• 📝 Generate docstrings

🧪 Generate unit tests (beta)

• Create PR with unit tests
• Post copyable unit tests in a comment
• Commit unit tests in branch fix/unstake-approval-label-steth

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

_{Comment @coderabbitai help to get the list of available commands and usage tips.}

[premiumjibles]

Looks good 👌