feat: hyperevm and monad treasury addies#11890
Conversation
As sent by prof. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
|
No actionable comments were generated in the recent review. 🎉 📝 WalkthroughWalkthroughThese changes add two new DAO treasury constants and register MonadMainnet and HyperEvmMainnet in treasury and swapper helper mappings to recognize those networks. Changes
Estimated code review effort🎯 2 (Simple) | ⏱️ ~10 minutes Suggested labels
Suggested reviewers
Poem
🚥 Pre-merge checks | ✅ 4✅ Passed checks (4 passed)
✏️ Tip: You can configure your own custom pre-merge checks in the settings. ✨ Finishing touches
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
There was a problem hiding this comment.
Caution
Some comments are outside the diff and can’t be posted inline due to platform limitations.
⚠️ Outside diff range comments (1)
packages/swapper/src/swappers/utils/helpers/helpers.ts (1)
36-63:⚠️ Potential issue | 🟠 MajorAdd missing
HyperEvmMainnetcase toisNativeEvmAssetHyperEvmMainnet is included in the treasury mapping (line 80) and is fully supported across the codebase, but has no corresponding case in
isNativeEvmAsset. This causes HyperEVM's native asset to incorrectly returnfalse, affecting multiple swappers that use this function to determine approval requirements and handle native assets. Add the case using the existinghyperEvmAssetIdconstant.
NeOMakinG
left a comment
There was a problem hiding this comment.
https://jam.dev/c/d52352f2-915e-4485-b958-98c82a20eb66
I did log and try a swap (which is useless btw as relay use our BASE treasury address and near the near one!
But: https://jam.dev/c/316928f9-7ed6-42aa-af12-ac42db5bcb55
Tested with accross and noticed the treasury address in the TX details, looks good to me!
Description
Add HyperEVM and Monad treasury addresses, as sent by prof.
0x35339070f178dC4119732982C23F5a8d88D3f8a30x35339070f178dC4119732982C23F5a8d88D3f8a3Issue (if applicable)
N/A
Risk
Low - adding new treasury address constants and chain ID mappings only.
Across swapper treasury address resolution for HyperEVM and Monad chains.
Testing
Engineering
Operations
N/A - Across not live yet
Screenshots (if applicable)
N/A
Summary by CodeRabbit