Merged
Conversation
Contributor
|
Important Review skippedDraft detected. Please check the settings in the CodeRabbit UI or the You can disable this status message by setting the Use the checkbox below for a quick retry:
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Production changes - testing required
Chainflip Lending
Introduces Chainflip lending with deposit, supply, withdraw, and borrow flows. Test the full lending lifecycle - depositing to the Chainflip state chain, supplying assets, borrowing against collateral, and withdrawing positions.
Thorchain Solana swapper
Enables swapping SOL and SPL tokens via Thorchain. Test Solana swaps (both native SOL and SPL tokens) through the Thorchain route - verify quotes, approvals, and successful broadcasts.
Yield fixes
Surfaces StakeKit API errors as user-facing toasts when yield quotes fail, and fixes the yield detail page selecting the wrong account for multi-account positions. Test yield quote error scenarios (e.g. bad params, network errors) and verify the correct account is pre-selected on the yield detail page for wallets with multiple accounts.
Trade UI
Caps chain icons in the trade asset search at 4 with a +N overflow badge. Open trade asset search for a multi-chain asset and verify chain icons cap at 4 with an overflow count.
TCY staking
Adds error toasts when TCY stake/unstake fails (wallet rejection or broadcast error). Test rejecting a TCY stake or unstake transaction in the wallet and verify an error toast appears instead of a silent failure.
BSC broadcast
Falls back to public RPC for BSC transaction broadcasts when unchained is unavailable. Regression testing only - verify BSC sends and swaps still broadcast successfully under normal conditions.
Fixes, deps, and infra
No testing required.
Dev/local only - no production testing required
No dev-only gated changes in this release.