feat: switch ethers JSON-RPC provider to StaticJsonRpcProvider#6223
Merged
gomesalexandre merged 3 commits intodevelopfrom Feb 19, 2024
Merged
feat: switch ethers JSON-RPC provider to StaticJsonRpcProvider#6223gomesalexandre merged 3 commits intodevelopfrom
gomesalexandre merged 3 commits intodevelopfrom
Conversation
Contributor
Author
|
Current dependencies on/for this PR:
This stack of pull requests is managed by Graphite. |
This was referenced Feb 15, 2024
14 tasks
4565503 to
a85f27c
Compare
Base automatically changed from
feat_ethers_provider_no_module_eval
to
develop
February 19, 2024 11:26
ab15bed to
5a0dd6d
Compare
kaladinlight
approved these changes
Feb 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Description
... and inject it to
MarketServiceManagerandinvestor-foxy, to avoid multiple instantiations that trigger calls toeth_chainId.No batching, but less requests in the end, which means things are effectively faster and more performant.
Pull Request Type
Issue (if applicable)
Risk
Testing
Engineering
eth_chainIdpayloads aymoreOperations
Screenshots (if applicable)
Develop
eth_chainIdAnd many, many more
This diff
eth_chainIdNow only called once by
BaseTransactionParser