fix: preserve background notifications after end_turn#149
fix: preserve background notifications after end_turn#149Gujiassh wants to merge 4 commits intoshareAI-lab:mainfrom
Conversation
|
@Gujiassh is attempting to deploy a commit to the crazyboym's projects Team on Vercel. A member of the Team first needs to authorize it. |
86a75cd to
f2621a4
Compare
|
Follow-up note: this branch was rebuilt from current main around the background-notification wait logic, and the focused regression checks pass locally ( |
f2621a4 to
51f1157
Compare
|
Follow-up note: I rebuilt this branch again from the latest available main snapshot, preserved the no-assistant-ack contract, and reran the focused background notification regression checks locally ( |
|
Status update: after the latest refresh, this branch still has no visible code-side CI failures. The only remaining blockers are the two Vercel team-authorization statuses on the project account side. |
51f1157 to
e62d5ae
Compare
|
Follow-up note: I rebuilt this branch once more directly on top of the latest current main, so it now carries only the background-notification wait fix and its focused regression tests. The refreshed head is |
e62d5ae to
9fc952c
Compare
|
Status update: this branch has now been refreshed on top of the current main head (). The remaining visible blockers are still the Vercel team-authorization statuses; there is no newly surfaced code-side failure on the branch itself. |
|
Correction to the previous note: this branch is now refreshed on top of the current main head. The remaining visible blockers are still only the Vercel team-authorization statuses; no new code-side failure appeared after the refresh. |
…otifications-clean
|
Refreshed this branch onto the latest Local verification after the refresh:
The background-task notification fix is still intact on the refreshed branch. The remaining failing PR checks appear to be the same external Vercel authorization gates, not a code regression on this branch. |
…clean' into fix/background-task-notifications-clean
|
Follow-up: the refreshed branch is now pushed too, and it includes the fork branch reconciliation as well. Re-run after that reconciliation:
So the branch is refreshed, reconciled, and still locally green. The remaining red checks still look like the same external Vercel authorization gates rather than a regression on the branch. |
Summary
end_turnEnd-user benefit
When a long-running background command finishes right after the model returns
end_turn, the current examples can exit before the result is ever surfaced back into the conversation. This change makes the background result reliably show up in the transcript instead of silently disappearing.Testing
python -m pytest tests/test_background_notifications.py -qpython -m py_compile agents/s08_background_tasks.py agents/s_full.py tests/test_background_notifications.py