Skip to content

[Fix] React Helmet 검색엔진 반영 안되는 이슈 배포 테스트 #429

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kyuhho merged 2 commits into from
Dec 23, 2024
Merged

[Fix] React Helmet 검색엔진 반영 안되는 이슈 배포 테스트 #429

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6a62cf0
fix: remove showing undefine in helmet (#426)
kyuhho Dec 23, 2024
18d3150
chore: remove meta tag from index.html to fix not appling issue (#426)
kyuhho Dec 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 0 additions & 5 deletions public/index.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,10 +84,6 @@
/>

<meta name="theme-color" content="#ffffff" />
<meta
name="description"
content="나와 비슷한 경험을 공유하는 사람들과 익명으로 부담없이 연애상담을 나눠보세요."
/>

<link rel="apple-touch-icon" href="%PUBLIC_URL%/favicon.ico" />
<!--
Expand All @@ -104,7 +100,6 @@
work correctly both with client-side routing and a non-root public URL.
Learn how to configure a non-root public URL by running `npm run build`.
-->
<title>셰어마인드 - 경험 공유 연애상담 플랫폼</title>
</head>

<body>
Expand Down
8 changes: 8 additions & 0 deletions src/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,8 +1,16 @@
import Router from 'Router';
import { Helmet } from 'react-helmet';

function App() {
return (
<div className="App" style={{ height: '100%', width: '100%' }}>
<Helmet>
<title>셰어마인드 - 경험 공유 연애상담 플랫폼</title>
<meta
name="description"
content="나와 비슷한 경험을 공유하는 사람들과 익명으로 부담없이 연애상담을 나눠보세요."
/>
</Helmet>
<Router />
</div>
);
Expand Down
11 changes: 7 additions & 4 deletions src/components/Buyer/BuyerOpenConsultDetail/MainQuestionSection.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -131,10 +131,13 @@ function MainQuestionSection() {

return (
<>
<Helmet>
<title>{`${card?.title} | 셰어마인드 공개 상담`}</title>
<meta name="description" content={card?.content} />
</Helmet>
{card && (
<Helmet>
<title>{`${card?.title} | 셰어마인드 공개 상담`}</title>
<meta name="description" content={card?.content} />
</Helmet>
)}

<MainQuestionWrapper>
<MainQuestionText>
<div className="row1">
Expand Down
Loading