Use tropical years as 'year' unit #334
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sharkdp
force-pushed
the
tropical-year
branch
2 times, most recently
from
dd25627 to
b0ed73c
Compare
We follow GNU units and Frink here and use the mean tropical year for the `year` unit. See `numbat/modules/units/time.nbt` for details. The Gregorian year is still available as `gregorian_year`. closes #321
sharkdp
force-pushed
the
tropical-year
branch
from
b0ed73c to
9f7b8b6
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We follow GNU units and Frink here and use the mean tropical year for the
yearunit. Seenumbat/modules/units/time.nbtfor details.The Gregorian year is still available as
gregorian_year.closes #321