Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add SVG icon and more PNG icon sizes to assets #340

Merged
merged 3 commits into from
Feb 12, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
12 changes: 12 additions & 0 deletions .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -213,6 +213,10 @@ jobs:
# README and LICENSE files
cp "README.md" "LICENSE-MIT" "LICENSE-APACHE" "$ARCHIVE_DIR"

# Desktop file and icons
mkdir "$ARCHIVE_DIR/assets"
cp "assets/numbat.desktop" assets/numbat-*x*.png "assets/numbat.svg" "$ARCHIVE_DIR/assets"

# Numbat prelude
cp -r numbat/modules "$ARCHIVE_DIR"

Expand Down Expand Up @@ -262,6 +266,14 @@ jobs:
install -Dm644 "LICENSE-MIT" "${DPKG_DIR}/usr/share/doc/${DPKG_BASENAME}/LICENSE-MIT"
install -Dm644 "LICENSE-APACHE" "${DPKG_DIR}/usr/share/doc/${DPKG_BASENAME}/LICENSE-APACHE"

# Desktop file and icons
install -Dm644 "assets/numbat.desktop" "${DPKG_DIR}/usr/share/applications/numbat.desktop"
install -Dm644 "assets/numbat.svg" "${DPKG_DIR}/usr/share/icons/hicolor/scalable/apps/numbat.svg"

for s in 16 22 24 32 48 64 128 256 512; do
install -Dm644 "assets/numbat-${s}x${s}.png" "${DPKG_DIR}/usr/share/icons/hicolor/${s}x${s}/apps/numbat.png"
done

# Numbat prelude
mkdir -p "${DPKG_DIR}/usr/share/${DPKG_BASENAME}"
cp -r numbat/modules "${DPKG_DIR}/usr/share/${DPKG_BASENAME}"
Expand Down
Binary file added assets/numbat-128x128.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed assets/numbat-1600.png
Binary file not shown.
Binary file modified assets/numbat-16x16.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed assets/numbat-196x196.png
Binary file not shown.
Binary file added assets/numbat-22x22.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added assets/numbat-24x24.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added assets/numbat-256x256.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified assets/numbat-32x32.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed assets/numbat-410.png
Binary file not shown.
Binary file added assets/numbat-48x48.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added assets/numbat-512x512.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file added assets/numbat-64x64.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file removed assets/numbat-800.png
Binary file not shown.
Binary file removed assets/numbat.png
Binary file not shown.
80 changes: 80 additions & 0 deletions assets/numbat.svg
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
10 changes: 7 additions & 3 deletions book/src/cli-installation.md
Original file line number Diff line number Diff line change
Expand Up @@ -127,6 +127,10 @@ If this variable is set during compilation, the specified path will be compiled
In order to test that everything is working as intended, you can open `numbat` and type `let meter = 2`. The
path in the error message should point to the specified location (and *not* to `<builtin>/…`).

If your OS uses `.desktop` files, you should probably also install `assets/numbat.desktop` and `assets/numbat-*x*.png` to their
appropriate locations (typically `/usr/share/applications` and `/usr/share/icons` respectively) so that users can e.g. pin
Numbat to GNOME's Dash.
If your OS uses `.desktop` files, you should probably also install:

- `assets/numbat.desktop` (typically to `/usr/share/applications`)
- `assets/numbat.svg` (typically to `/usr/share/icons/hicolor/scalable/apps`)
- `assets/numbat-*x*.png` (typically to e.g. `/usr/share/icons/hicolor/32x32/apps`, depending on each icon's size)

This allows users to e.g. pin Numbat to GNOME's Dash.
Loading