fix: resolve duplicate statSync calls, typo, and update platform support#13
Open
eren-karakus0 wants to merge 1 commit intoshelby:mainfrom
Open
fix: resolve duplicate statSync calls, typo, and update platform support#13eren-karakus0 wants to merge 1 commit intoshelby:mainfrom
eren-karakus0 wants to merge 1 commit intoshelby:mainfrom
Conversation
- Optimize buildEntries() in file-tree-navigator.ts by caching fs.statSync() result instead of calling it twice per entry - Fix typo "Rretrieve" -> "Retrieve" in download.ts - Update README system requirements to include Windows (WSL), matching the win32 entry already listed in package.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
buildEntries()infile-tree-navigator.tsby caching thefs.statSync()result instead of calling it twice per directory entry. This reduces unnecessary syscalls during file tree navigation.Rretrieve→Retrieveindownload.tscomment.win32entry already listed inpackage.json.Changes
src/guide/util/file-tree-navigator.tsstatSyncresult to avoid duplicate call per entrysrc/guide/download.tsREADME.mdTest plan
buildEntries()produces identical output with singlestatSynccallpackage.jsonalready listswin32inosfieldNote
Low Risk
Documentation and minor CLI UX/performance changes with no behavioral changes to network/storage operations.
Overview
Updates the quickstart docs to explicitly list Windows (WSL) as a supported platform.
Fixes a small typo in the download guide comment, and slightly optimizes
buildEntries()infile-tree-navigator.tsby caching thefs.statSync()directory check per entry to avoid duplicate filesystem calls while building the selection list.Written by Cursor Bugbot for commit a6b84fe. This will update automatically on new commits. Configure here.