Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jibit driver added and unwanted crc32 uuid fixed. #132

Closed
wants to merge 22 commits into from
Closed

jibit driver added and unwanted crc32 uuid fixed. #132

wants to merge 22 commits into from

Conversation

m-ostadi
Copy link

@m-ostadi m-ostadi commented Feb 5, 2022

Description

fixes #124 unwanted crc32 on input uuids

fixes #85 jibit driver added.

uuid() method fluency fixed.

saman verify TraceNo parameter corrected.

addding status code to exceptions #183

m-ostadi added 22 commits July 4, 2021 16:23
# Conflicts:
#	src/Drivers/Asanpardakht/Asanpardakht.php
#	src/Drivers/Idpay/Idpay.php
#	src/Drivers/Irankish/Irankish.php
#	src/Drivers/Local/Local.php
#	src/Drivers/Nextpay/Nextpay.php
#	src/Drivers/Parsian/Parsian.php
#	src/Drivers/Payir/Payir.php
#	src/Drivers/Paypal/Paypal.php
#	src/Drivers/Payping/Payping.php
#	src/Drivers/Paystar/Paystar.php
#	src/Drivers/Poolam/Poolam.php
#	src/Drivers/Sadad/Sadad.php
#	src/Drivers/Saman/Saman.php
#	src/Drivers/Sepehr/Sepehr.php
#	src/Drivers/Yekpay/Yekpay.php
# Conflicts:
#	src/Drivers/Asanpardakht/Asanpardakht.php
# Conflicts:
#	src/Drivers/Jibit/Jibit.php
#	src/Drivers/Jibit/JibitBase.php
# Conflicts:
#	config/payment.php
#	src/Drivers/Paystar/Paystar.php
#	src/Drivers/Sadad/Sadad.php
#	src/Drivers/Saman/Saman.php
# Conflicts:
#	config/payment.php
@khanzadimahdi
Copy link
Member

22 commits!!! it seems you have lots of changes. please close this merge request and send another one that must be related to the merge request's title.

@m-ostadi
Copy link
Author

m-ostadi commented Feb 9, 2022

Most of them are from an old pull request #85 for adding jibit driver.
You could reopen that to cut down the jibit related commits. I fixed it's random order_id in a recent commit.

@khanzadimahdi khanzadimahdi added the invalid This doesn't seem right label Mar 3, 2022
@khanzadimahdi
Copy link
Member

please send a valid pull request and squash all related commits into one commit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
invalid This doesn't seem right
Projects
None yet
Development

Successfully merging this pull request may close these issues.

دلیل استفاده از crc32 توی بعضی از درایور ها چیه؟
2 participants