fix(skills): resolve cross-skill rule inconsistencies (1.24.1)#178
Merged
Conversation
- documentation-criteria: align the ADR file-count matrix with the automation rule (ADR conditional at 6+; Design Doc + Work Plan required at 3-5) - coding-standards / typescript-rules: unify the comment policy (code-first, comment the "why") - frontend-technical-spec: add the Error Boundary exception to the class-component rule Applied across en/ja. Bumps version to 1.24.1. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Resolves a set of conflicting normative rules surfaced by a read-through of the skills, mirroring the kind of cleanup done upstream in the plugin repo. No rules were loosened; changes either resolve an internal contradiction or complete an incomplete rule. Patch version bumped to
1.24.1.Changes
[ADR if conditions apply]), Design Doc + Work Plan are the required items, the automation rule now keys off 6+ and routes back to the ADR conditions, and the 3-5 row isRequired(matchingsubagents-orchestration-guideand the controlledMandatory / Not required / Conditionally mandatoryvocabulary —Recommendedwas an orphan term).typescript-rules("comment the why, not the what"). Reframed to code-first with a why/limitation/public-API test, in positive form (BP-001) and without the bullet-1/bullet-2 overlap (Principle 2).frontend-typescript-rulesallows class components solely for Error Boundaries. Added the Error Boundary exception so the two agree.Applied across en/ja.
Validation
check-skills-index: all 26 skills consistent across en/ja.🤖 Generated with Claude Code