Skip to content

fix(skills): resolve cross-skill rule inconsistencies (1.24.1)#178

Merged
shinpr merged 1 commit into
mainfrom
fix/skill-rule-inconsistencies
Jun 21, 2026
Merged

fix(skills): resolve cross-skill rule inconsistencies (1.24.1)#178
shinpr merged 1 commit into
mainfrom
fix/skill-rule-inconsistencies

Conversation

@shinpr

@shinpr shinpr commented Jun 21, 2026

Copy link
Copy Markdown
Owner

Summary

Resolves a set of conflicting normative rules surfaced by a read-through of the skills, mirroring the kind of cleanup done upstream in the plugin repo. No rules were loosened; changes either resolve an internal contradiction or complete an incomplete rule. Patch version bumped to 1.24.1.

Changes

  • documentation-criteria — the Creation Decision Matrix made ADR unconditionally required at 6+ files while the AI Automation Rules suggested ADR at 5+. Aligned both: ADR is conditional at 6+ ([ADR if conditions apply]), Design Doc + Work Plan are the required items, the automation rule now keys off 6+ and routes back to the ADR conditions, and the 3-5 row is Required (matching subagents-orchestration-guide and the controlled Mandatory / Not required / Conditionally mandatory vocabulary — Recommended was an orphan term).
  • coding-standards — the comment policy said "describe what the code does," contradicting typescript-rules ("comment the why, not the what"). Reframed to code-first with a why/limitation/public-API test, in positive form (BP-001) and without the bullet-1/bullet-2 overlap (Principle 2).
  • frontend-technical-spec — the class-component rule said "deprecated" with no exception, while frontend-typescript-rules allows class components solely for Error Boundaries. Added the Error Boundary exception so the two agree.

Applied across en/ja.

Validation

  • check-skills-index: all 26 skills consistent across en/ja.
  • Pre-commit hooks pass.

🤖 Generated with Claude Code

- documentation-criteria: align the ADR file-count matrix with the automation rule (ADR conditional at 6+; Design Doc + Work Plan required at 3-5)
- coding-standards / typescript-rules: unify the comment policy (code-first, comment the "why")
- frontend-technical-spec: add the Error Boundary exception to the class-component rule

Applied across en/ja. Bumps version to 1.24.1.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
@shinpr shinpr self-assigned this Jun 21, 2026
@shinpr
shinpr merged commit bc59a9a into main Jun 21, 2026
1 check passed
@shinpr
shinpr deleted the fix/skill-rule-inconsistencies branch June 21, 2026 03:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant