Use the context provide to UsageWithContext public function #1837
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, at work, we use gopsutil. We wanted to use the
disk.UsageWithContext
to allow setting some timeout when calling the Usage function.We realized that the function UsageWithContext does not use the ctx provided.
It think would be a good addition to this great package.
That way, the user can do:
Before adding a test or applying this pattern to other functions
*WithContext,
I wanted to know if we would be okay with having it in the package. If so, I can add tests and extend the pattern to the rest of the*WithContext
functions.Looking forward for your feedback.