Skip to content

Fixes #223 : remove incompatible numpy pin from webui requirements #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
randyy179 wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Fixes #223 : remove incompatible numpy pin from webui requirements #224

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a7d0d23
fix: remove incompatible numpy pin from webui requirements
randyy179 Mar 10, 2026
8c08af6
fix: relax numpy requirement in webui dependencies
randyy179 Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion webui/requirements.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
flask==2.3.3
flask-cors==4.0.0
Copy link

Copilot AI Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

webui/app.py and webui/run.py import NumPy directly, but webui/requirements.txt no longer lists numpy as an explicit dependency. Even though pandas currently pulls NumPy transitively, this makes the Web UI’s direct dependency set unclear and can break installs that don’t resolve transitive deps. Consider adding numpy back without the incompatible hard pin (or with a lower-bound consistent with pandas’ requirements).

Suggested change
flask-cors==4.0.0
flask-cors==4.0.0
numpy>=1.22.4

Copilot uses AI. Check for mistakes.
Copy link
Copy Markdown
Author

@randyy179 randyy179 Mar 10, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. NumPy is a direct dependency because both webui/app.py and webui/run.py import it directly.

I updated webui/requirements.txt to keep NumPy explicit while removing the incompatible hard pin. It now uses a compatible lower bound (numpy>=1.26.0) alongside pandas==2.2.2.

pandas==2.2.2
numpy==1.24.3
numpy>=1.26.0
plotly==5.17.0
torch>=2.1.0
huggingface_hub==0.33.1