Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new section to manage users #376

Open
wants to merge 8 commits into
base: main
Choose a base branch
from

Conversation

acelaya
Copy link
Member

@acelaya acelaya commented Feb 5, 2025

Part of #6

Implement a basic list of users with pagination.

This PR does not cover creating, editing or deleting users.

@acelaya acelaya force-pushed the feature/users-list branch 2 times, most recently from 1fe476e to f5333ab Compare February 11, 2025 08:11
@acelaya acelaya force-pushed the feature/users-list branch 2 times, most recently from 40b3aa8 to 9cdda75 Compare February 16, 2025 10:34
Copy link

codecov bot commented Feb 19, 2025

Codecov Report

Attention: Patch coverage is 81.35593% with 44 lines in your changes missing coverage. Please review.

Project coverage is 69.10%. Comparing base (e4b89b9) to head (2ac3a5e).
Report is 17 commits behind head on main.

Files with missing lines Patch % Lines
app/fe-kit/Paginator.tsx 76.92% 0 Missing and 15 partials ⚠️
app/fe-kit/pagination.ts 64.00% 0 Missing and 9 partials ⚠️
app/routes/users/manage-users.tsx 85.71% 0 Missing and 8 partials ⚠️
app/fe-kit/Table.tsx 84.78% 0 Missing and 7 partials ⚠️
app/auth/auth.server.ts 50.00% 0 Missing and 1 partial ⚠️
app/common/MainHeader.tsx 90.00% 0 Missing and 1 partial ⚠️
app/routes.ts 0.00% 1 Missing ⚠️
app/routes/users/RoleBadge.tsx 90.90% 0 Missing and 1 partial ⚠️
app/users/UsersService.server.ts 95.00% 0 Missing and 1 partial ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main     #376      +/-   ##
==========================================
+ Coverage   65.95%   69.10%   +3.14%     
==========================================
  Files          32       37       +5     
  Lines         893     1123     +230     
  Branches      130      172      +42     
==========================================
+ Hits          589      776     +187     
- Misses        174      175       +1     
- Partials      130      172      +42     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant