Skip to content

fix: ensure consistent empty state for marketplace search results#332

Merged
calvadev merged 3 commits intoshopstr-eng:mainfrom
23bsm038-Mahi:fix-empty-state-v4
Apr 7, 2026
Merged

fix: ensure consistent empty state for marketplace search results#332
calvadev merged 3 commits intoshopstr-eng:mainfrom
23bsm038-Mahi:fix-empty-state-v4

Conversation

@23bsm038-Mahi
Copy link
Copy Markdown
Contributor

@23bsm038-Mahi 23bsm038-Mahi commented Apr 4, 2026

Summary

Ensure a consistent empty state when marketplace search returns no results.

Changes

  • Removed duplicate empty state rendering
  • Simplified conditional logic for displaying results vs no-results
  • Ensured empty state shows when !isProductsLoading && filteredProducts.length === 0

Why this matters

  • Prevents blank UI when no products match the search
  • Improves user experience with clear feedback
  • Keeps behavior consistent across all filter/search scenarios

Scope

  • UI-only change
  • No impact on existing search or filtering logic
  • Minimal and focused update

Testing

  • Verified empty state appears correctly when no results are returned
  • Confirmed no regressions in product listing behavior

@vercel
Copy link
Copy Markdown

vercel bot commented Apr 4, 2026

@23bsm038-Mahi is attempting to deploy a commit to the shopstr-eng Team on Vercel.

A member of the Team first needs to authorize it.

@23bsm038-Mahi
Copy link
Copy Markdown
Contributor Author

Removed the duplicate empty state and simplified the rendering logic to ensure a single, consistent no-results UI across all scenarios.

@23bsm038-Mahi 23bsm038-Mahi changed the title fix: improve empty state for marketplace search results fix: ensure consistent empty state for marketplace search results Apr 5, 2026
@GautamBytes
Copy link
Copy Markdown
Contributor

LGTM Now!!

@calvadev calvadev merged commit 6ceae11 into shopstr-eng:main Apr 7, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants