fixed the profile upload icon issue and product card layout in mobille layout#348
Open
Aryan0699 wants to merge 4 commits intoshopstr-eng:mainfrom
Open
fixed the profile upload icon issue and product card layout in mobille layout#348Aryan0699 wants to merge 4 commits intoshopstr-eng:mainfrom
Aryan0699 wants to merge 4 commits intoshopstr-eng:mainfrom
Conversation
|
@Aryan0699 is attempting to deploy a commit to the shopstr-eng Team on Vercel. A member of the Team first needs to authorize it. |
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
UI polish focused on mobile layout: improves user profile banner/avatar positioning, stabilizes layout when scrollbars appear, and adjusts product grid behavior for small screens.
Changes:
- Reworked user profile banner + avatar overlay positioning and upload icon placement.
- Stabilized page width by adding global
scrollbar-gutter: stable. - Tweaked nav profile hover/focus styling and adjusted mobile product grid to single-column with padding.
Reviewed changes
Copilot reviewed 6 out of 7 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| utils/nostr/fetch-service.ts | Minor formatting/indentation adjustments in review update logic. |
| styles/globals.css | Adds stable scrollbar gutter to reduce layout shift. |
| pages/settings/user-profile.tsx | Updates banner container + avatar overlay layout and upload icon positioning. |
| components/utility-components/profile/profile-dropdown.tsx | Adjusts avatar sizing/styling in the dropdown trigger. |
| components/nav-top.tsx | Simplifies profile hover styling to opacity-based behavior. |
| components/home/marketplace.tsx | Formatting tweaks in JSX and conditional rendering alignment. |
| components/display-products.tsx | Changes product grid to 1-column on mobile with padding, responsive columns on larger screens. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Contributor
Author
|
Apologies for the branch drift — I’ll take care of this. |
Contributor
|
LGTM Now! |
Contributor
no worries |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Files that can be ignored
marketplace.tsx,fetch-service.tsResolved or fixed issue
Fixes #342Screenshots
Before
After
Affirmation